Fit / Fill / Zoom bug

[efb4f5ff-1298-471a-8973-3d47447115dc]

Checklist

• I am using the latest version - 0.20.10
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

1. Open a random video
2. Watch the video in fullscreen
3. Choose Fit / Fill or Zoom
4. Go out of fullscreen
5. Close the video
6. Open another random video
7. watch the video in fullscreen
8. Notice that the option u chose changed to another one

Actual behaviour

The value doesnt stay the same.
if u choose Zoom then it will default to Fill
if u choose Fill it will default to Fit
if u choose Fit it will default to Zoom

Expected behavior

Value must stay the same!

Screenshots/Screen recordings

signal-2021-02-17-110941.mp4

Logs

Device info

• Android version/Custom ROM version: Android 11 / Graphene OS
• Device model: Google Pixel 3a XL

[litetex]

It think I managed to find the problem by reviewing the code.
However I'm not 100% sure, because I don't have NewPipe setup locally for developing.

The problem is very likely on

NewPipe/app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java

Lines 487 to 488 in 0d522aa

	player.getPrefs().edit().putInt(
	player.getContext().getString(R.string.last_resize_mode), resizeMode).apply();

When the a new resizeMode is set by calling nextResizeModeAndSaveToPrefs (from

NewPipe/app/src/main/java/org/schabi/newpipe/player/Player.java

Lines 3613 to 3617 in 0d522aa

	void onResizeClicked() {
	if (binding != null) {
	setResizeMode(nextResizeModeAndSaveToPrefs(this, binding.surfaceView.getResizeMode()));
	}
	}

), it uses the old resizeMode to get the next/new one.
However it stores the old one in the preferences.

So when switching from ZOOM to FIT, it returns FIT (which is used for the current video), but stores ZOOM in the preferences (used for the next videos)

This was probably introduced by commit f6e2dd1 from @Stypox last month

[TobiGr]

Can you test the APK from #5792 and tell me, whether the bug is fixed?

[litetex]

@TobiGr
LGTM:
https://user-images.githubusercontent.com/40789489/110525980-8cb68400-8115-11eb-8880-ebc190655e07.mp4

Tested with a virtual Pixel 3a