Skip to content

Commit

Permalink
Simply code by directly casting after instanceof in if-conditions
Browse files Browse the repository at this point in the history
  • Loading branch information
TobiGr committed Jul 19, 2023
1 parent c6242d3 commit fb23e75
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions app/src/main/java/org/schabi/newpipe/util/StreamItemAdapter.java
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,7 @@ private View getCustomView(final int position,
int woSoundIconVisibility = View.GONE;
String qualityString;

if (stream instanceof VideoStream) {
final VideoStream videoStream = ((VideoStream) stream);
if (stream instanceof VideoStream videoStream) {
qualityString = videoStream.getResolution();

if (hasAnyVideoOnlyStreamWithNoSecondaryStream) {
Expand All @@ -153,16 +152,15 @@ private View getCustomView(final int position,
woSoundIconVisibility = View.INVISIBLE;
}
}
} else if (stream instanceof AudioStream) {
final AudioStream audioStream = ((AudioStream) stream);
} else if (stream instanceof AudioStream audioStream) {
if (audioStream.getAverageBitrate() > 0) {
qualityString = audioStream.getAverageBitrate() + "kbps";
} else {
qualityString = context.getString(R.string.unknown_quality);
}
} else if (stream instanceof SubtitlesStream) {
qualityString = ((SubtitlesStream) stream).getDisplayLanguageName();
if (((SubtitlesStream) stream).isAutoGenerated()) {
} else if (stream instanceof SubtitlesStream subtitlesStream) {
qualityString = subtitlesStream.getDisplayLanguageName();
if (subtitlesStream.isAutoGenerated()) {
qualityString += " (" + context.getString(R.string.caption_auto_generated) + ")";
}
} else {
Expand All @@ -187,8 +185,8 @@ private View getCustomView(final int position,
sizeView.setVisibility(View.GONE);
}

if (stream instanceof SubtitlesStream) {
formatNameView.setText(((SubtitlesStream) stream).getLanguageTag());
if (stream instanceof SubtitlesStream subtitlesStream) {
formatNameView.setText(subtitlesStream.getLanguageTag());
} else {
if (mediaFormat == null) {
formatNameView.setText(context.getString(R.string.unknown_format));
Expand All @@ -213,8 +211,8 @@ private View getCustomView(final int position,
private boolean checkHasAnyVideoOnlyStreamWithNoSecondaryStream() {
for (int i = 0; i < streamsWrapper.getStreamsList().size(); i++) {
final T stream = streamsWrapper.getStreamsList().get(i);
if (stream instanceof VideoStream) {
final boolean videoOnly = ((VideoStream) stream).isVideoOnly();
if (stream instanceof VideoStream videoStream) {
final boolean videoOnly = videoStream.isVideoOnly();
if (videoOnly && secondaryStreams.get(i) == null) {
return true;
}
Expand Down

0 comments on commit fb23e75

Please sign in to comment.