Mypy check untyped

[lopuhin]

Enable checking untyped defs with mypy.

In order to do that, I had to add __init__ methods to base classes. To slightly avoid repetition, I removed explicit attr.id lines and instead add them based on __init__ signature - I don't see obvious downsides here or ways it could be misused (this is a bit magical, but attr.ib is also magical), but still that might cause problems or confusion - if so, we can roll back the attributes, while having __init__ methods too.

[codecov-io]

Current coverage is 95.98% (diff: 100%)

Merging #60 into master will increase coverage by 0.07%

@@             master        #60   diff @@
==========================================
  Files            26         27     +1   
  Lines          1221       1245    +24   
  Methods           0          0          
  Messages          0          0          
  Branches        201        205     +4   
==========================================
+ Hits           1171       1195    +24   
  Misses           26         26          
  Partials         24         24          

Diff Coverage	File Path
•••••••••• 100%	eli5/lime/samplers.py
•••••••••• 100%	eli5/sklearn/text.py
•••••••••• 100%	eli5/base.py
•••••••••• 100%	eli5/sklearn/utils.py
•••••••••• 100%	eli5/_feature_weights.py
•••••••••• 100%	new eli5/base_utils.py
•••••••••• 100%	eli5/sklearn/unhashing.py
•••••••••• 100%	eli5/formatters/text.py

Powered by Codecov. Last update d7c8d45...6851e1f

[kmike]

See also: python-attrs/attrs#97

[lopuhin]

Thanks! Looks like python/mypy#1310 is a blocker for python-attrs/attrs#97, and the mypy issue looks very far away, sadly.

I though if this trick with generating attributes from __init__ could be useful for attrs, but it seems to be a bit too hacky to expose in such a base library.

[kmike]

Yeah, that mypy issue is a blocker. Also, it proposes a plugin architecture, but this means fix would be mypy-specific and other users (eg. PyCharm) won't benefit from that.