Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#94] 온보딩 화면 QA 반영 #97

Merged
merged 8 commits into from
Jul 20, 2023
Merged

[Fix/#94] 온보딩 화면 QA 반영 #97

merged 8 commits into from
Jul 20, 2023

Conversation

yeoncheong
Copy link
Contributor

🎀 Related Issues

close #94

🤔 What Did You Do

  • InputInfoAcitivity 성별 칩 체크
  • 초대받는 측 NotifyTimeActivity에 시간 띄우기
  • OnboardingFinishActivity layout1도 뒤로가기 버튼 활성화
  • 온보딩 초대하는 측 시간 설정 12시 -> 24시로 설정되게, 분은 텍스트로 30 들어오도록
  • 카카오톡 메세지 개행문자 미반영 수정

⁉️ etc

  • NotifyTimeActivity에 시간 띄우는 것은 테스트가 필요합니다

@yeoncheong yeoncheong added fix 버그 수정 연진 labels Jul 20, 2023
@yeoncheong yeoncheong requested a review from ss99x2002 July 20, 2023 17:34
@yeoncheong yeoncheong self-assigned this Jul 20, 2023
@yeoncheong yeoncheong requested a review from yujin-00 July 20, 2023 17:34
Copy link
Member

@ss99x2002 ss99x2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!!!!!! 수고티비

@@ -74,8 +74,8 @@ class InviteCodeDialogFragment(private val inviteUserName: String, private val i
binding.btnSendInvitation.setOnClickListener {
val defaultFeed = FeedTemplate(
content = Content(
title = "${inviteUserName}으로부터 초대가 왔어요. \\n초대 코드 : $inviteCode",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

드디어 초대코드 공유가 완성되었군여 !!~~@!!@!!!!!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예이~!!!!

binding.tvTitle.text = "매일 ${hourText} ${hour}시 반에\n교신을 보내줄게"
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이걸 해내네;;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내가해냄;;;

Copy link

@yujin-00 yujin-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일주일은 6일이야.

왠 줄 알아?

널 기다리느라 '목'이 빠졌거든.

보고싶었어 연진아🫶

@yeoncheong yeoncheong merged commit a650524 into develop Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 수정 연진
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 온보딩 화면 QA 반영
3 participants