Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/#95] 답변, 설정 QA 반영 #96

Merged
merged 4 commits into from
Jul 20, 2023
Merged

[Fix/#95] 답변, 설정 QA 반영 #96

merged 4 commits into from
Jul 20, 2023

Conversation

ss99x2002
Copy link
Member

🎀 Related Issues

close #95

🤔 What Did You Do

  • 리스트-> 문답화면 자신과 상대 답변 안뜨는 현상 (xml 수정)
  • 답변 -> 답변 확인 dialog 답변 안뜨는 현상 (viewModel 확인)
  • 설정 노션 확정링크 반영
  • Log -> Timber 로 변경
  • string 추출

⁉️ etc

  • 다른 부분은 필요한 로그가 뭔지 구분하기 어려워서 제 부분만 Timber로 변경했습니다.
  • 스트링은 보고 필요한 부분들은 추출했습니다.

@ss99x2002 ss99x2002 requested review from yeoncheong and yujin-00 July 20, 2023 17:34
@ss99x2002 ss99x2002 self-assigned this Jul 20, 2023
@ss99x2002 ss99x2002 added fix 버그 수정 서현 labels Jul 20, 2023
yujin-00
yujin-00 approved these changes Jul 20, 2023
View reviewed changes
Copy link

@yujin-00 yujin-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너의 완벽함은 다 거품이야.

언블리버블

yeoncheong
yeoncheong approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@yeoncheong yeoncheong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String 깔끔 이슈~!!
수고하셨습니다
이제 진짜 끝이 보인다

@ss99x2002 ss99x2002 merged commit 526583c into develop Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeoncheong yeoncheong yeoncheong approved these changes

@yujin-00 yujin-00 yujin-00 approved these changes

Assignees

@ss99x2002 ss99x2002

Labels
fix 버그 수정 서현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 답변 화면 QA 반영
3 participants
@ss99x2002 @yujin-00 @yeoncheong