-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Design/#4] 온보딩 질문 화면 UI 구현 #5
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
faf814f
[Design/#4] QuestActivity 전체 뷰 구현
ss99x2002 a08ed3e
[Design/#4] 세부 질문 fragment 구현
ss99x2002 3a2f8b5
[Design/#4] 시간 통지 화면 구현
ss99x2002 37ac7b4
[Design/#4] tools:text로 변경
ss99x2002 5f9a9f5
[Feat/#4] intent 추가
ss99x2002 1ea9cac
[Design/#4] button 글자 크기 조정
ss99x2002 e727a47
[Design/#4] 코드리뷰 반영
ss99x2002 5bbe80e
Merge branch 'develop' of https://github.com/Team-Umbba/Umbba-Android…
ss99x2002 9a03d05
[Design/#4] margin 수정
ss99x2002 de751b2
[Design/#4] 시간공지뷰 activity 이름 수정
ss99x2002 29858c1
[Design/#4] font style 적용, chip 변경
ss99x2002 88be54b
[Design/#4] next button drawable 이름 수정
ss99x2002 4525214
[Design/#4] 오타수정
ss99x2002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
app/src/main/java/com/sopt/umbba_android/presentation/onboarding/NotifyTimeActivity.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package com.sopt.umbba_android.presentation.onboarding | ||
|
||
import android.content.Intent | ||
import android.os.Bundle | ||
import com.sopt.umbba_android.R | ||
import com.sopt.umbba_android.databinding.ActivityNotifyTimeBinding | ||
import com.sopt.umbba_android.util.binding.BindingActivity | ||
|
||
class NotifyTimeActivity : BindingActivity<ActivityNotifyTimeBinding>(R.layout.activity_notify_time) { | ||
override fun onCreate(savedInstanceState: Bundle?) { | ||
super.onCreate(savedInstanceState) | ||
setClickButton() | ||
} | ||
|
||
private fun setClickButton() { | ||
with(binding) { | ||
btnGoPast.setOnClickListener { | ||
startActivity(Intent(this@NotifyTimeActivity, QuestActivity::class.java)) | ||
} | ||
} | ||
} | ||
} |
20 changes: 20 additions & 0 deletions
20
app/src/main/java/com/sopt/umbba_android/presentation/onboarding/QuestActivity.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.sopt.umbba_android.presentation.onboarding | ||
|
||
import android.os.Bundle | ||
import com.sopt.umbba_android.R | ||
import androidx.fragment.app.Fragment | ||
import com.sopt.umbba_android.databinding.ActivityQuestBinding | ||
import com.sopt.umbba_android.util.binding.BindingActivity | ||
|
||
class QuestActivity : BindingActivity<ActivityQuestBinding>(R.layout.activity_quest) { | ||
override fun onCreate(savedInstanceState: Bundle?) { | ||
super.onCreate(savedInstanceState) | ||
changeFragment(QuestSubFragment()) | ||
} | ||
|
||
private fun changeFragment(fragment: Fragment) { | ||
supportFragmentManager.beginTransaction() | ||
.add(R.id.fragment_question, fragment) | ||
.commit() | ||
} | ||
} |
21 changes: 21 additions & 0 deletions
21
app/src/main/java/com/sopt/umbba_android/presentation/onboarding/QuestSubFragment.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package com.sopt.umbba_android.presentation.onboarding | ||
|
||
import android.os.Bundle | ||
import android.view.LayoutInflater | ||
import android.view.View | ||
import android.view.ViewGroup | ||
import androidx.fragment.app.Fragment | ||
import com.sopt.umbba_android.R | ||
import com.sopt.umbba_android.databinding.FragmentQuestOneBinding | ||
import com.sopt.umbba_android.util.binding.BindingFragment | ||
|
||
class QuestSubFragment : BindingFragment<FragmentQuestOneBinding>(R.layout.fragment_quest_one) { | ||
|
||
override fun onCreateView( | ||
inflater: LayoutInflater, | ||
container: ViewGroup?, | ||
savedInstanceState: Bundle? | ||
): View? { | ||
return super.onCreateView(inflater, container, savedInstanceState) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<selector xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<item android:color="@color/grey_btn_checked_solid" android:state_checked="true" /> | ||
<item android:color="@color/grey_btn_stroke"/> | ||
<item android:color="@color/grey_btn_solid"/> | ||
</selector> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<selector xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<item android:color="@color/white" android:state_checked="true" /> | ||
<item android:color="@color/black"/> | ||
</selector> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<layer-list xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<item android:id="@android:id/background"> | ||
<shape> | ||
<corners android:radius="18dp" /> | ||
<solid android:color="@color/grey_D2D2D2" /> | ||
</shape> | ||
</item> | ||
|
||
<item android:id="@android:id/progress" | ||
android:top="1dp" | ||
android:bottom="1dp" | ||
android:left="1dp" | ||
android:right="1dp"> | ||
|
||
<scale android:scaleWidth="100%"> | ||
<shape> | ||
<corners android:radius="18dp"/> | ||
<solid android:color="@color/grey_666666"/> | ||
</shape> | ||
</scale> | ||
</item> | ||
</layer-list> |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<selector xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<item android:state_checked="false"> | ||
<shape android:shape="rectangle"> | ||
<corners android:radius="50dp" /> | ||
<stroke android:width="1dp" android:color="@color/grey_CFCFCF" /> | ||
<solid android:color="@color/grey_EAEAEA" /> | ||
</shape> | ||
</item> | ||
<item android:state_checked="true"> | ||
<shape android:shape="rectangle"> | ||
<corners android:radius="50dp" /> | ||
<stroke android:color="@color/grey_CFCFCF" android:width="1dp"/> | ||
<solid android:color="@color/grey_747474"/> | ||
</shape> | ||
</item> | ||
</selector> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<selector xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<item android:state_checked="true" android:color="@color/white"> | ||
</item> | ||
<item android:state_checked="false" android:color="@color/black"> | ||
</item> | ||
</selector> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<layout xmlns:app="http://schemas.android.com/apk/res-auto"> | ||
|
||
<data> | ||
|
||
<variable | ||
name="titleText" | ||
type="String" /> | ||
</data> | ||
|
||
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:layout_width="match_parent" | ||
android:layout_height="match_parent"> | ||
|
||
<include | ||
android:id="@+id/layout_appbar" | ||
layout="@layout/basic_appbar" /> | ||
|
||
<TextView | ||
android:id="@+id/tv_title" | ||
style="@style/AndroidHead1SemiBold24" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:layout_marginStart="24dp" | ||
android:layout_marginTop="18dp" | ||
android:text="@string/go_past_title" | ||
android:textColor="@color/black" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toBottomOf="@id/layout_appbar" /> | ||
|
||
<androidx.appcompat.widget.AppCompatButton | ||
android:id="@+id/btn_go_past" | ||
android:layout_width="match_parent" | ||
android:layout_height="60dp" | ||
android:layout_margin="24dp" | ||
android:background="@drawable/shape_black_fill_r50_rect" | ||
android:text="@string/go_past" | ||
android:textColor="@color/white" | ||
android:textSize="16sp" | ||
android:textStyle="bold" | ||
app:layout_constraintBottom_toBottomOf="parent" /> | ||
|
||
</androidx.constraintlayout.widget.ConstraintLayout> | ||
</layout> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<layout xmlns:app="http://schemas.android.com/apk/res-auto"> | ||
|
||
<data> | ||
|
||
<variable | ||
name="titleText" | ||
type="String" /> | ||
</data> | ||
|
||
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:layout_width="match_parent" | ||
android:layout_height="match_parent"> | ||
|
||
<include | ||
android:id="@+id/layout_appbar" | ||
layout="@layout/basic_appbar" /> | ||
|
||
<TextView | ||
android:id="@+id/tv_title" | ||
style="@style/AndroidHead1SemiBold24" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:layout_marginStart="24dp" | ||
android:layout_marginTop="12dp" | ||
android:text="@string/quest_activity_title" | ||
android:textColor="@color/black" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toBottomOf="@id/layout_appbar" /> | ||
|
||
<ProgressBar | ||
android:id="@+id/progress_bar" | ||
style="@style/Widget.AppCompat.ProgressBar.Horizontal" | ||
android:layout_width="match_parent" | ||
android:layout_height="5dp" | ||
android:layout_marginHorizontal="24dp" | ||
android:layout_marginTop="12dp" | ||
android:progressDrawable="@drawable/progress_bar_quest" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toBottomOf="@id/tv_title" /> | ||
|
||
<FrameLayout | ||
android:id="@+id/fragment_question" | ||
android:layout_width="match_parent" | ||
android:layout_height="335dp" | ||
android:layout_marginHorizontal="24dp" | ||
android:layout_marginTop="24dp" | ||
app:layout_constraintBottom_toBottomOf="parent" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toTopOf="parent" /> | ||
|
||
<androidx.appcompat.widget.AppCompatButton | ||
android:layout_width="match_parent" | ||
android:layout_height="60dp" | ||
android:layout_margin="24dp" | ||
android:background="@drawable/sel_btn_next" | ||
android:enabled="false" | ||
android:text="@string/btn_next" | ||
android:textColor="@color/white" | ||
android:textSize="16sp" | ||
app:layout_constraintBottom_toBottomOf="parent" /> | ||
|
||
</androidx.constraintlayout.widget.ConstraintLayout> | ||
|
||
</layout> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 버튼을 만들어야해서 selector랑 color랑 그 외 것들을 추가해두었는데 겹치는 것 같네요. 둘 다 머지한 후에 한 명의 것으로 합쳐야 할 것 같습니다!