Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design/#29] Color System 및 바뀐 placeHolder 적용 #36

Merged
merged 20 commits into from
Jul 10, 2023
Merged

[Design/#29] Color System 및 바뀐 placeHolder 적용 #36

merged 20 commits into from
Jul 10, 2023

Conversation

yeoncheong
Copy link
Contributor

🎀 Related Issues

close #29

🤔 What Did You Do

  • 필요한 컬러 시스템 추가
  • 필요 없는 grey 삭제
  • 도형 네이밍 변경 및 추가 및 삭제
  • 바뀐 placeholder 적용
  • 추가된 layout 적용

⁉️ etc

  • 바뀐 부분이 많아 스크린샷은 생략합니다,
  • 모든 AppCompatButton에 그림자를 삭제했습니다. 적용 안 된 부분이 있다면 적용해주세요!
  • 모든 버튼에 color system이 적용되었습니다. 마찬가지로 적용 안 된 부분이 있다면 적용해주세요.
  • 필요없는 grey 컬러들은 모두 삭제되었고, switch에 사용한 색만 현재 남아있으나 이번에 색상 적용하면서 없어졌다면 삭제해주세요.

yeoncheong added 18 commits July 10, 2023 14:39
@yeoncheong yeoncheong added delete 코드 삭제 design UI 추가 및 수정 연진 labels Jul 10, 2023
@yeoncheong yeoncheong requested a review from ss99x2002 July 10, 2023 13:14
@yeoncheong yeoncheong self-assigned this Jul 10, 2023
ss99x2002
ss99x2002 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@ss99x2002 ss99x2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전부 수정하느라 수고하셨습니다!! 머지하면 pull 받고 안된부분 수정할게요

app/src/main/res/layout/activity_notify_time.xml Outdated
android:layout_height="wrap_content"
android:layout_marginStart="28dp"
android:layout_marginTop="12dp"
android:text="초대자가 선택한 시간에 따라 푸시 알림을 보내드려요"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

텍스트 추출해주세요!

app/src/main/res/values/colors.xml

<color name="kakao_yellow">#FBE44D</color>

<color name="grey_999999">#999999</color>
Copy link
Member

@ss99x2002 ss99x2002 Jul 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것도 삭제해도되지않나요? (grey)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etc에 작성한대로 제가 풀 받은 곳에서는 사용하고 있어서 삭제하지 않았습니다! 색상 바뀐 것으로 적용되었다면 삭제할게요~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아항 제가 삭제할게욤

@yeoncheong yeoncheong merged commit 1d91ba0 into develop Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ss99x2002 ss99x2002 ss99x2002 approved these changes

Assignees

@yeoncheong yeoncheong

Labels
delete 코드 삭제 design UI 추가 및 수정 연진
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] Color system 및 바뀐 placeHolder 적용
2 participants
@yeoncheong @ss99x2002