Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design/#19] 홈 화면 UI 구현 #21

Merged
merged 4 commits into from
Jul 9, 2023
Merged

[Design/#19] 홈 화면 UI 구현 #21

merged 4 commits into from
Jul 9, 2023

Conversation

ss99x2002
Copy link
Member

🎀 Related Issues

close #19

🤔 What Did You Do

  • HomeFragment UI 구현
  • HomeFragment 이미지 배경 임시 등록

⁉️ etc

  • 홈 뷰는 배경을 서버로부터 받아오기 때문에, home fragment 클래스에 coil로 받아 올 예정입니다.
  • 지금은 임시로 마루를 넣었습니다.

@ss99x2002 ss99x2002 requested a review from yeoncheong July 9, 2023 13:20
@ss99x2002 ss99x2002 self-assigned this Jul 9, 2023
@ss99x2002 ss99x2002 added design UI 추가 및 수정 서현 labels Jul 9, 2023
Copy link
Contributor

@yeoncheong yeoncheong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
ctrl+alt+l 누르는 것 잊지 말아주세요~

Comment on lines +10 to +11
<FrameLayout
android:id="@+id/fragment_fv"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 FrameLayout의 용도는 무엇인가요?
그리고 왜 FrameLayout을 사용했는지도 궁금합니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거.. Bottom nav가 없는 상태라 그냥 fragment 임시로 보려고 만든거에요!! 지금은 지웠습니다

<androidx.constraintlayout.widget.ConstraintLayout
android:id="@+id/layout_answer_other"
android:layout_width="match_parent"
android:layout_height="172dp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레이아웃의 높이의 경우 값을 숫자로 지정하는 방식을 지양해주세요.
기기 사이즈 대응이 어렵습니다!
높이의 경우 layout의 내부에 있는 여러 View들의 marginTop 또는 marginBottom을 통해 채워주세요.

<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/layout_root"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout의 id 컨벤션을 통일할 필요가 있는 것 같습니다.
저는 보통 대문자를 따와서 ConstraintLayout일 경우 cl_..., FrameLayout의 경우 fl_... 형태로 작성합니다.

android:background="@drawable/shape_grey_fill_r84_rect"
android:textAppearance="@style/BrandTypeBigRegular20"
android:text="#1 가장 오래된 기억"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 텍스트가 추출이 안됐습니다!

Comment on lines +12 to +13
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout_width가 match_parent일 경우에는 따로 Start_toStart와 End_toEnd를 지정할 필요가 없습니다!
이미 가로 길이를 모두 채우고 있기 때문입니다. 이 점 알아두세요~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵~

@ss99x2002 ss99x2002 merged commit b08ad2f into develop Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design UI 추가 및 수정 서현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] 홈 화면 UI 구현
2 participants