[Feat/#109] 엔딩페이지 구현 & 답변화면 UT 반영 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeoncheong
approved these changes
Aug 31, 2023
Comment on lines
+60
to
+63
| if (it.index == 8 && viewModel.isShowedEndingPage()) { | ||
| viewModel.setStateObserveIndex() | ||
| startForResult.launch(Intent(requireActivity(), EndingActivity::class.java)) | ||
| } |
There was a problem hiding this comment.
저는 인덱스 값만 검사하면 되는줄 알았는데 인덱스만으로는 체크가 안되는군요!!
There was a problem hiding this comment.
인덱스로만 검사하면 엑스를 누르고 홈으로 돌아오면 여전히 idx=8이라서 엔딩페이지가 또 뜨는 문제로 조건을 하나 더 따져야했습니다 haha
Comment on lines
+29
to
+36
| private fun setClickBtnSave() { | ||
| with(binding) { | ||
| viewModel.answer.observe(this@AnswerActivity) { | ||
| btnSave.isEnabled = !it.isNullOrBlank() | ||
| } | ||
| btnSave.setOnClickListener { | ||
| showConfirmDialog() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎀 Related Issues
close #109
🤔 What Did You Do
📸 Screenshot
_2023_08_28_20_02_14_505.mp4