Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 커스텀 에러 코드 적용 #144

Merged
merged 7 commits into from
Aug 13, 2024
Merged

[REFACTOR] 커스텀 에러 코드 적용 #144

merged 7 commits into from
Aug 13, 2024

Conversation

Chan531
Copy link
Contributor

@Chan531 Chan531 commented Aug 12, 2024

✨ Related Issue

📝 기능 구현 명세

image

  • 인증 관련 커스텀 response
    image
  • 기존 api error response

🐥 추가적인 언급 사항

  • 인증 관련 로직만 커스텀 에러 코드가 필요하다는 클라 요청에 인증 로직만 따로 구분해주었습니다.
  • auth/info의 AuthenticationResponse가 쓰이는 곳이 없는 거 같은데 없애도 될까요?

@Chan531 Chan531 self-assigned this Aug 12, 2024
paragon0107
paragon0107 reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@paragon0107 paragon0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 변경하느라 고생하셨습니다!

src/main/java/com/tiki/server/auth/info/AuthenticationResponse.java Outdated Show resolved Hide resolved
src/main/java/com/tiki/server/common/dto/AuthResponse.java Outdated Show resolved Hide resolved
@Chan531 Chan531 merged commit be87ed2 into develop Aug 13, 2024
1 check passed
@Chan531 Chan531 deleted the refactor/#140-error branch August 13, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paragon0107 paragon0107 paragon0107 approved these changes

Assignees

@Chan531 Chan531

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 커스텀 에러코드 적용
2 participants
@Chan531 @paragon0107