Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Explore curatoin view model 적용 #469

Merged
merged 14 commits into from
Jul 22, 2023
Merged

[Feat] Explore curatoin view model 적용 #469

merged 14 commits into from
Jul 22, 2023

Conversation

JIWON1923
Copy link
Collaborator

@JIWON1923 JIWON1923 commented Jun 18, 2023 •
edited
Loading

관련 이슈

구현/변경 사항

  • Read Curation View Model 생성했습니다.
  • 특정 모델에 init 함수를 정의해서 조금 편하게 쓸 수 있도록 수정했습니다.
  • viewModel의 의존성은 Navigation Stack에서 제공합니다
  • 63370d5 의 경우, 그린이 작업해주신 부분인데 같이 수정해서 업로드합니다.

6/25 변경사항

  • Explore Curation Views에 대한 View Model 생성
  • Navigation Stack Curation.self, CuratonType.self로 수정

스크린샷

뷰 변경사항은 없습니다.

추가 공유사항

  • 수정 후 cell의 업데이트 일어나지 않음
  • UserCurationCell에 선언된 curation을 Binding으로 변경해야합니다.

@JIWON1923 JIWON1923 added this to the 12th Sprint milestone Jun 18, 2023
@JIWON1923 JIWON1923 requested review from JMM00 and jim4020key June 18, 2023 14:16
jim4020key
jim4020key requested changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@jim4020key jim4020key left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 탈퇴한사용자가 제대로 표시 되지 않는데 확인 부탁해요 ~~~~~ !!

HappyAnding/HappyAnding/ViewModel/ReadCurationViewModel.swift Outdated Show resolved Hide resolved
HappyAnding/HappyAnding/Views/ExploreCurationViews/ReadCurationView.swift Show resolved Hide resolved
HappyAnding/HappyAnding/Views/ExploreCurationViews/ReadCurationView.swift Show resolved Hide resolved
HappyAnding/HappyAnding/Views/ExploreCurationViews/ReadCurationView.swift Show resolved Hide resolved
HappyAnding/HappyAnding/Views/ExploreCurationViews/ReadCurationView.swift Outdated Show resolved Hide resolved
HappyAnding/HappyAnding/ViewModel/ReadCurationViewModel.swift Outdated Show resolved Hide resolved
HappyAnding/HappyAnding/Views/ExploreCurationViews/ReadCurationView.swift Outdated Show resolved Hide resolved
@JIWON1923 JIWON1923 changed the title [Feat] #468 read curatoin view model 적용 [Feat] Explore curatoin view model 적용 Jun 25, 2023
@JIWON1923 JIWON1923 requested a review from jim4020key June 25, 2023 10:45
@JIWON1923
Copy link
Collaborator Author

@jim4020key 꼼꼼한 리뷰 감사해요~!

JMM00
JMM00 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@JMM00 JMM00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

덕분에 참고가 많이 되었습니다! 제가 확인한 부분에서는 문제없이 동작했습니다👍

jim4020key
jim4020key approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@jim4020key jim4020key left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

탈퇴한 사용자 disable은 readshortcutviewmodel PR에서 처리하겠습니다 ~!
쏘이 짱 🫶

HappyAnding/HappyAnding/ViewModel/ExploreCurationViewModels/ExploreCurationViewModel.swift Outdated Show resolved Hide resolved
HappyAnding/HappyAnding/ViewModel/ExploreCurationViewModels/ListCurationViewModel.swift Outdated Show resolved Hide resolved
HappyAnding/HappyAnding/ViewModel/ExploreCurationViewModels/ReadCurationViewModel.swift Outdated Show resolved Hide resolved
JIWON1923 and others added 3 commits July 22, 2023 14:50
@JIWON1923 @jim4020key
Update HappyAnding/HappyAnding/ViewModel/ExploreCurationViewModels/Ex…
70cc4e0 
…ploreCurationViewModel.swift

Co-authored-by: GREEN (JIMIN KIM) <[email protected]>
@JIWON1923 @jim4020key
[Refactor] #472 - Private
0649903 
Co-authored-by: GREEN (JIMIN KIM) <[email protected]>
@JIWON1923 @jim4020key
[Refactor] #472 - Private
4ecac9c 
Co-authored-by: GREEN (JIMIN KIM) <[email protected]>
@JIWON1923 JIWON1923 merged commit dc35877 into develop Jul 22, 2023
@JIWON1923 JIWON1923 deleted the feature/468-readCuratoinViewModel branch July 22, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim4020key jim4020key jim4020key approved these changes

@JMM00 JMM00 JMM00 approved these changes

Assignees

@JIWON1923 JIWON1923

@jim4020key jim4020key

Labels
Type-Feature New feature
Projects
None yet
Milestone
12th Sprint
Development

Successfully merging this pull request may close these issues.

[Feat] Read Curation View Model 생성
3 participants
@JIWON1923 @JMM00 @jim4020key