Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] write curation view model #476

Closed
wants to merge 59 commits into from
Closed

[Feat] write curation view model #476

wants to merge 59 commits into from

Conversation

JMM00
Copy link
Member

@JMM00 JMM00 commented Jul 20, 2023

관련 이슈

구현/변경 사항

  • WriteCurationViewModel 생성 및 적용
  • CheckboxShortcutCell 위치를 CurationSetView안으로 변경

스크린샷

화면 상의 변경사항 없습니다.

추가 공유사항

  • 이전 pr이 머지되어야 완전하게 작동됩니다. (브랜치 실행 시 HappyAndingApp 파일에서 ShortcutZipViewModel 선언 시 ShortcutsZipViewModel.shared로 변경 후 실행해야합니다.)

JIWON1923 and others added 15 commits June 18, 2023 23:11
@JIWON1923
[Style] #468 init 함수 생성
435e84c
@JIWON1923 @jim4020key
[Feat] View Model 생성
784843a 
Co-authored-by: jim4020key <[email protected]>
@JIWON1923 @jim4020key
[Refactor] Curation 데이터 활용
63370d5 
Co-authored-by: jim4020key <[email protected]>
@JIWON1923
[Style] #468 - 파일 명 수정
94e3b87
@JIWON1923
[Feat] #472 - ListCurationViewModel 생성
400f320
@JIWON1923
[Feat] #472 - Explore Curation View Model 생성
e37e624
@JIWON1923
[Feat] #472 - ViewModel 적용
fe76a7c
@JIWON1923
[Style] #472 - 뷰모델 폴더 구조 생성
949476c
@JIWON1923
[Feat] #472 - NavigationCurationType 삭제
7a1afe9
@JIWON1923 @jim4020key
[Refactor] #468 - 코드리뷰 반영
21f7f14 
Co-authored-by: jim4020key <[email protected]>
@JIWON1923
[Fix] #468 - 탈퇴한 회원 정보 오류 수정
3a50e44
@JMM00
[Feat] #470 - WriteCurationViewModel 생성
e01ab0d 
- 변수 위치 수정
- NavigationStack 변수 타입 변경 -> WriteCurationViewModel.Self

todo:
- CheckBoxShortcutCell 합치기
- 좋아요&작성한 단축어 정렬 확인하기
@JMM00
[Feat] #470 - checkbox shortcut 뷰모델 연결
d636f8d
@JMM00
[Feat] #470 - checkboxCell 합치기.
aee2cbc 
- viewBuilder 이용
- idx -> index로 수정
@JMM00
[Style] 불필요한 파일 삭제
c2a2621
@JMM00 JMM00 self-assigned this Jul 20, 2023
JIWON1923 and others added 11 commits July 22, 2023 14:50
@JIWON1923 @jim4020key
Update HappyAnding/HappyAnding/ViewModel/ExploreCurationViewModels/Ex…
70cc4e0 
…ploreCurationViewModel.swift

Co-authored-by: GREEN (JIMIN KIM) <[email protected]>
@JIWON1923 @jim4020key
[Refactor] #472 - Private
0649903 
Co-authored-by: GREEN (JIMIN KIM) <[email protected]>
@JIWON1923 @jim4020key
[Refactor] #472 - Private
4ecac9c 
Co-authored-by: GREEN (JIMIN KIM) <[email protected]>
@JIWON1923
Merge pull request #469 from DeveloperAcademy-POSTECH/feature/468-rea…
dc35877 
…dCuratoinViewModel

[Feat] Explore curatoin view model 적용
@jim4020key
[Feat] #473 - Add ShowProfileViewModel
7f322fa
@jim4020key
[Feat] #473 - Add ReadShortcutViewModel
69a9c14
@jim4020key
[Feat] #473 - Add ReadShortcutViewModel to UpdateShortcutView
c39b1bd
@jim4020key
[Feat] #473 - Move properties to view model
30d6706
@jim4020key
[Feat] #473 - Sort comments
2d7c12b
@jim4020key
[Style] #473 - Fix typo
2db1839
@jim4020key
[Feat] #473 - Add .onDisappear method
ae563ed
HanGyeongjun
HanGyeongjun approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@HanGyeongjun HanGyeongjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 데이터의 세계는... 어렵군요

jim4020key
jim4020key reviewed Aug 12, 2023
View reviewed changes
Copy link
Collaborator

@jim4020key jim4020key left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • NavigationStackModel에 사용하지 않는 WriteCurationInfoType 삭제해주세요!
  • 아래 화면에서 취소 버튼 동작하는 지랑 추천모음집 업로드 잘 되는 지 확인부탁드려요 !! 제 시뮬에서는 동작하지 않아요 😭

JMM00 added 12 commits August 13, 2023 12:44
@JMM00
[Feat] #470 - WriteCurationViewModel 생성
bcb0803 
- 변수 위치 수정
- NavigationStack 변수 타입 변경 -> WriteCurationViewModel.Self

todo:
- CheckBoxShortcutCell 합치기
- 좋아요&작성한 단축어 정렬 확인하기
@JMM00
[Feat] #470 - checkbox shortcut 뷰모델 연결
b1ebefa
@JMM00
[Feat] #470 - checkboxCell 합치기.
46cf7ce 
- viewBuilder 이용
- idx -> index로 수정
@JMM00
[Style] 불필요한 파일 삭제
45d051a
@JMM00
Merge branch 'feature/470-writeCurationViewModel' of https://github.c…
82cebc1 
…om/DeveloperAcademy-POSTECH/MacC-Team-HappyAnding into feature/470-writeCurationViewModel

# Conflicts:
#	HappyAnding/HappyAnding/Views/WriteCurationViews/WriteCurationSetView.swift
@JMM00
[Feat] #470 - isWriting 연결
caf5adf
@JMM00
[Style] 불필요한 부분 삭제
89eff63
@JMM00
[Feat] #470 - userCurationCell 업데이트 함수 추가
20b0b76
@JMM00
[Feat] #470 - userCurationCell의 curation을 Binding으로 변경
7f5e7e6
@JMM00
[Fix] resolve error
788e06b 
- Publishing changes from within view updates 해결 -> DispatchQueue.main.async
- 텍스트필드 focused된 채로 업로드 버튼 클릭 시 앱이 멈추는 에러 해결 -> focused 해제 후 업로드 동작하도록 수정
@JMM00
[Feat] #470 - 네비게이션 초기화 추가
a98e568
@JMM00
[Fix] resolve update NavigationAuthority bound path tried to update m…
a53867b 
…ultiple times per frame
@JMM00 JMM00 closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim4020key jim4020key jim4020key left review comments

@HanGyeongjun HanGyeongjun HanGyeongjun approved these changes

@JIWON1923 JIWON1923 Awaiting requested review from JIWON1923

Assignees

@JMM00 JMM00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] Write Curation ViewModel 생성
4 participants
@JMM00 @jim4020key @HanGyeongjun @JIWON1923