Ignore result of runs with nightly builds in CI job status #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this doesn't make any difference to the status indicator on the PR but the status badge does appear to be showing as passing: 
|
giordano
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
This also appears green in the actions page. I still think the old UI of Travis was nicer, but I guess we have to do with what we have now. Thanks for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replicates the approach in JuliaTime/TimeZones.jl#418 also discussed in actions/runner#2347 and https://github.com/orgs/community/discussions/15452, for trying to have failures of the CI runs on Julia nightly version not cause the overall workflow status to be a failure. I think that this would mean the workflow status (and so status badge, tick / cross indicator in commit history) would remain green on nightly failures while still showing the failures in the individual job statuses, though I'm not totally sure on this so partly opening up this PR to test. Ideally we would have some alternative visual indicator for the overall workflow status to highlight some optional jobs failing, but given the above linked discussions suggest this has been a long requested GitHub Actions feature with no movement as of yet, I would say having the workflow statuses indicating passing even when nightly builds are failing is overall preferable to having them always showing as failing in this case.