Fix Observers/Spectators

[OZETobi]

Is your feature request related to a problem? Please describe.
I know it's been said, that this fix is low priority. But I personally think this one would be amazing to have before our End Season Tournaments in February. Currently there are 3 issues with Obs:

• Only 2 slots.
• Messes up the colors of players in lobby, and in-game of players & creeps.
• Ultra zoomed-in, and -zoom command doesn't work.

The weird thing about Obs is that the 2 Obs spots work as West Legion & East Legion. When you are Obs you literally "become" the West/East Legion. The creeps and sendings are "your" units. You can click them and command them, but (ofc) they don't respond. So you can't control them or bug them. But again, I guess this is why there are only 2 slots and why it fucks up the colors of players and creeps.

So why would it be nice to have extra Obs/Spec slots? Imagine the publicity this could bring, if we got like 10-12 Observer slots for Tournament Semi-Finals and Grand-Finals. I'm sure many pub players would love to watch the finals of a 1v1/2v2 Tournament, and we can leave the slots open for all. Potentially it's 10-12 players who can end up being motivated to join our server and play league. Also brings discussion, learning and competitivity to LTD.

Describe the solution you'd like

• Fix Observers/Spectators.
• Add extra slots - the more the better.
• Fix -zoom command for Observers.

[marcoabreu]

I could imagine that the logic is configured that it assumes certain player slots as bot players. These slots are then the observers and thus the assignment issue happens. But just a theory

[marcoabreu]

I checked and it assumes player slots 8 and 9 for the west and east bots. So we have to make sure that observers are either player 10+ or make the 8 and 9 conditional

[STOPTHECOUNT]

Did you see Player 10, 11, 12 and 15?

[STOPTHECOUNT]

It had nothing to do with the players (wouldn't have made sense) or the jass-file.

[marcoabreu]

It's not about missing observers but that the colors and controls get messy

[STOPTHECOUNT]

Yeah, that's in the code and easy to change.

[STOPTHECOUNT]

I think -zoom won't be possible for observers but I changed the default values, which should give observers a nice overview.
First two observer slots remain bugged for now. Work-a-round for now is to just close the first two obs-slots or live with it's effects.
Can be rewritten later, when the code is cleaner.

[marcoabreu]

I think we should leave the issue open then to fix the first two observer slots

[marcoabreu]

Thanks for fixing all the other issues!

[OZEuncubeus]

Hey matt, this one is done right?