Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Runloop, cell binding방식, 토스트메세지, loadingView 적용 (#190) #193

Merged
merged 7 commits into from
Nov 24, 2023

Conversation

ffalswo2
Copy link
Contributor

@ffalswo2 ffalswo2 commented Nov 24, 2023

🌱 작업한 내용

  • CurriculumView
  • CurriculumListWeekView
  • ArticleDetail
  • Login

각각의 뷰에 대해서 메인 스레드 관리, cell binding 방식 통일, 북마크 저장, 삭제, 요청 실패 토스트 메시지 추가했습니다.

ViewController의 bind메서드 내에서 UI에 데이터 바인딩을 하는 코드가 메인스레드에서 돌아가게끔 receive(on:) 메서드를 활용했습니다.

output.articleData
    .receive(on: RunLoop.main)
    .sink { ... }

Cell binding에 대한 내용은 #187 해당 PR에서 자세히 설명해두었습니다!

📸 스크린샷

Simulator Screen Recording - iPhone 13 mini - 2023-11-24 at 16 24 50

📮 관련 이슈

@ffalswo2 ffalswo2 added 🦁민재 민재's ♻️Refactoring 리펙터링 labels Nov 24, 2023
@ffalswo2 ffalswo2 added this to the 🦁2차 Refactor🦁 milestone Nov 24, 2023
@ffalswo2 ffalswo2 self-assigned this Nov 24, 2023
@ffalswo2 ffalswo2 merged commit 4ab06ce into main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️Refactoring 리펙터링 🦁민재 민재's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Runloop, cell binding방식, 토스트메세지, loadingView 적용
1 participant