[REFACTOR] Splash, Auth, ArticleCategory Coordinator에 Adaptor Pattern적용(#156) #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimscastle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#156] REFACTOR : Splash, Auth, ArticleCategory Coordinator에 Adaptor Pattern적용
🌱 작업한 내용
🌱 PR Point
Coordinator, ViewController, NavigationController사이의 강한순환참조에 관한고민이 필요합니다
navigation interface와 coordinator interface를 adaptor객체로 연결시켜주면서 두 interface사이의 depth를 두면서 단순히 adaptor의 변경만으로 coordinator를 변경하지 않은상태에서 viewcontroller의 화면전환 flow변경에 대응할수 있게 되었다, 결과적으로 비교적 core한 depth에 있는 coordinator layer는 외부 변화가 있을 때 변경될 가능성이 낮아지게되고 이는 코드 전체의 안정성을 향상시켜줄 수있습니다
외부변화가 발생했을때(화면전환 flow변경) adaptor를 새로만들어서 주입시켜주거나 adaptor를 수정하면 되기때문에 OCP(Open-Closed Principle) 원칙에도 부합해, 보다 유연한 설계를 할 수 있게됩니다
리팩과정에서 interface가 너무 많아져서 슬슬 코드를 읽고쓰는데 피로감이 들고있습니다 추상화, 관심사분리를 도입하는데있어서 trade off관계인것같지만 고민전에 러닝커브와 보일러플레이트를 고려하는게 필요한것같습니다
📸 스크린샷
📮 관련 이슈