Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Challenge Unit test #198

Closed
4 tasks done
kimscastle opened this issue Nov 30, 2023 · 0 comments · Fixed by #200
Closed
4 tasks done

[TEST] Challenge Unit test #198

kimscastle opened this issue Nov 30, 2023 · 0 comments · Fixed by #200
Assignees
@kimscastle
Labels
🦁의성 의성's 🧪Test 테스트
Milestone
🦁3차 Refactor🦁

Comments

@kimscastle
Copy link
Contributor

kimscastle commented Nov 30, 2023 •
edited
Loading

[TEST] Challenge Unit test

🍎 이슈 요약

  • Challenge관련 API, ViewModel, ViewController에 대한 Unit test를 진행합니다

✅ 체크 리스트

  • API test
  • ViewModel test
  • ViewController test
  • Coverage over 70%
@kimscastle kimscastle added 🦁의성 의성's 🧪Test 테스트 labels Nov 30, 2023
@kimscastle kimscastle added this to the 🦁3차 Refactor🦁 milestone Nov 30, 2023
@kimscastle kimscastle self-assigned this Nov 30, 2023
kimscastle added a commit that referenced this issue Dec 1, 2023
@kimscastle
[ADD] challenge api 성공 json파일 추가(#198)
f861b21
kimscastle added a commit that referenced this issue Dec 1, 2023
@kimscastle
[WIP] 챌린지 관련 unit test작성(#198)
e33b539
kimscastle added a commit that referenced this issue Dec 1, 2023
@kimscastle
[ADD] Challenge API호출 Unit test작성(#198)
7f55cc4
kimscastle added a commit that referenced this issue Dec 1, 2023
@kimscastle
[FIX] Challenge API Unit test로직 수정(#198)
df3de88
kimscastle added a commit that referenced this issue Dec 1, 2023
@kimscastle
[WIP] ChallengeViewModel Unit test작성중(#198)
eef019a
ffalswo2 added a commit that referenced this issue Dec 1, 2023
@ffalswo2
[WIP] fake app delegate 추가 (#198)
ee72a03
ffalswo2 added a commit that referenced this issue Dec 1, 2023
@ffalswo2
[WIP] ViewModel unit test navigation flow타입 확인만 하는 것으로 변경 (#198)
e7c3671
kimscastle added a commit that referenced this issue Dec 1, 2023
@kimscastle
[TEST] ChallengeViewModel Unit test 1차 Coverage 92.9%(#198)
4d73afe
kimscastle added a commit that referenced this issue Dec 1, 2023
@kimscastle
[TEST] ChallengeViewController Unitest작성중(#198)
e75ea55 
coverage 83.9%
kimscastle added a commit that referenced this issue Dec 1, 2023
@kimscastle
[TEST] ChallengeVC 버튼관련 test추가(#198)
a5d6bae 
coverage 87.1%
kimscastle added a commit that referenced this issue Dec 1, 2023
@kimscastle
[FIX] 메서드명 변경 및 필요없는 코드 삭제(#198)
475889c
@kimscastle kimscastle mentioned this issue Dec 1, 2023
Merged
kimscastle added a commit that referenced this issue Dec 3, 2023
@kimscastle
[FIX] 기존의 gurad문을 통한 언래핑 대신 XCTUnwrap를 이용한 언래핑으로 변경(#198)
cde9332
kimscastle added a commit that referenced this issue Dec 3, 2023
@kimscastle
[FIX] XCTestExpectation을 given으로 옮김(#198)
d4e708e
kimscastle added a commit that referenced this issue Dec 3, 2023
@kimscastle
[FIX] viewModel을 Stub에서 spy로 네이밍변경(#198)
7ef1d14
kimscastle added a commit that referenced this issue Dec 3, 2023
@kimscastle
[FIX] firebase오류해결(찬미가해결해줌)(#198)
0dbcde7 
test target -> Build Settings -> Testing -> TestHost의 경로가 //두개로 되어있는걸 /로 바꿈(더블클릭하면 /하나로되어있는데 그냥 /지우면 /한개로 뜸)
kimscastle added a commit that referenced this issue Dec 3, 2023
@kimscastle
[FIX] 기존 stub를 역할에따라 spy와 dummy로 변경(#198)
070f0be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimscastle kimscastle

Labels
🦁의성 의성's 🧪Test 테스트
Projects
None yet
Milestone
🦁3차 Refactor🦁
Development

Successfully merging a pull request may close this issue.

[TEST] Challenge Unit test code 작성 Team-LionHeart/LionHeart-iOS
1 participant
@kimscastle