Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #289 - 2차 스프린트 기능 QA 반영 #294

Open
wants to merge 47 commits into
base: develop
Choose a base branch
from
Open

[Fix] #289 - 2차 스프린트 기능 QA 반영 #294

wants to merge 47 commits into from
+578 −323

Commits on Nov 13, 2024

  1. [Fix] #289 - 메뉴 셀 포커스 시 border 컬러 변경

    @EunsuSeo01
    EunsuSeo01 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e2c00b9 View commit details
    Browse the repository at this point in the history

  2. [Fix] #289 - 메뉴 셀 1개일 때 하단 버튼 텍스트 변경

    @EunsuSeo01
    EunsuSeo01 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    111775a View commit details
    Browse the repository at this point in the history

  3. [Feat] #289 - 메뉴 셀 1개일 때 x 버튼 숨김 처리 로직 추가 

    제보하기의 메뉴 셀에도 동일하게 적용 완료함
    @EunsuSeo01
    EunsuSeo01 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3aebbff View commit details
    Browse the repository at this point in the history

  4. [Fix] #289 - 가격 텍스트 필드 normal, focused, error 스타일 활성화 로직 수정

    @EunsuSeo01
    EunsuSeo01 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b44f6b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. [Fix] #289 - 메뉴 추가 시 하단 버튼 활성화 타이밍 수정

    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8b0c33a View commit details
    Browse the repository at this point in the history

  2. [Fix] #289 - 메뉴 추가 및 수정 Req Body 구조체 재설정 

    MenuData에서 MenuRequestDTO로 구조를 변경하는 toMenuRequestDTO 함수도 추가함
    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3e7c773 View commit details
    Browse the repository at this point in the history

  3. [Fix] #289 - 메뉴 추가 url 수정

    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    586acda View commit details
    Browse the repository at this point in the history

  4. [Fix] #289 - 메뉴 추가 완료 화면 구현 및 완료 화면 init 파라미터 추가

    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    caa3d28 View commit details
    Browse the repository at this point in the history

  5. [Fix] #289 - 메뉴 추가 후 식당 상세로 돌아왔을 때 높이 알맞게 늘어나도록 수정 

    removeConstraints 후 다시 makeConstraints 함으로써 높이 안 늘어나던 이슈 해결
    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c11a3a4 View commit details
    Browse the repository at this point in the history

  6. [Fix] #289 - 완료 화면 네비바 없애기

    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7969db9 View commit details
    Browse the repository at this point in the history

  7. [Fix] #289 - viewWillAppear에서 메뉴 셀 초기화 

    다른 메뉴도 추가하기 클릭했을 때를 대비
    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    774b67e View commit details
    Browse the repository at this point in the history

  8. [Fix] #289 - doThisAgainButton 클릭 시에도 postNotification 호출되도록 구조 변경 

    doThisAgainButton 클릭 후 네비바의 뒤로가기 버튼 클릭 시에 식당 상세 화면이 나오는데
이때에도 업데이트 된 최신 메뉴 리스트를 보여주기 위해서
    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b54332b View commit details
    Browse the repository at this point in the history

  9. [Fix] #289 - 메뉴 불러오기 API 연동 및 연결 

    API 구현 전이라 임의로 식당 상세 보기의 API에서 메뉴 리스트만 가져와서 썼던 걸 새 API로 변경
    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    197caef View commit details
    Browse the repository at this point in the history

  10. [Fix] #289 - Response DTO 수정 

    서버가 dto 구조 하나로 통일해줘서 반영함
    @EunsuSeo01
    EunsuSeo01 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1f8f19f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. [Fix] #289 - 편집 화면에서 마지막 메뉴 삭제 시 Alert 문구 변경

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d6378dc View commit details
    Browse the repository at this point in the history

  2. [Fix] #289 - 마지막 메뉴 삭제 시 Alert 문구 및 로직 변경 

    편집에서 바로 삭제 시 로직 변경
수정 중에 가격 넘어서 삭제할 때에도 적용함
    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d4e7184 View commit details
    Browse the repository at this point in the history

  3. [Chore] #289 - StringLiterals 작성

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4be8f2b View commit details
    Browse the repository at this point in the history

  4. [Fix] #289 - VM의 modifiedMenuData 값을 선택된 메뉴 데이터로 초기화

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e1715b6 View commit details
    Browse the repository at this point in the history

  5. [Fix] #289 - 기존 적용 버튼을 수정 완료 버튼으로 변경 

    문구를 포함하여 버튼 로직 변경
    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f977c7b View commit details
    Browse the repository at this point in the history

  6. [Fix] #289 - 하단 수정 완료 버튼 초기 스타일 활성화로 변경

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5f437bb View commit details
    Browse the repository at this point in the history

  7. [Fix] #289 - 메뉴 가격 유효성 조건 추가 

    가격이 0보다 커야 함
    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4263a3d View commit details
    Browse the repository at this point in the history

  8. [Fix] #289 - 에러 스타일은 가격 텍스트필드일 때만 적용되도록 수정

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    624a152 View commit details
    Browse the repository at this point in the history

  9. [Chore] #289 - 변수명 변경 

    헷갈림
    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    34e3ec4 View commit details
    Browse the repository at this point in the history

  10. [Fix] #289 - 그냥 텍스트필드 클릭 시에도 수정 가능하도록 변경 

    원래는 연필 버튼 클릭 시에만 수정 가능하게 막아뒀었는데 이를 없앰
    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    aa3d659 View commit details
    Browse the repository at this point in the history

  11. [Fix] #289 - 메뉴 가격 에러 스타일 변경

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    eaab9a0 View commit details
    Browse the repository at this point in the history

  12. [Fix] #289 - 가격 에러일 때만 deleteMenuAccessoryView 뜨도록 재수정

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f14d99f View commit details
    Browse the repository at this point in the history

  13. Merge branch 'develop' into fix/#289

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f295b3a View commit details
    Browse the repository at this point in the history

  14. [Fix] #289 - 메뉴 텍스트필드 클릭 시 커서 맨 오른쪽으로 

    연필 버튼 클릭 시와 동일한 로직으로 동작하도록 탭 제스처 추가함
    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0acb686 View commit details
    Browse the repository at this point in the history

  15. [Fix] #289 - 하단 수정 완료 클릭 시에도 모달 뜨도록 수정

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4a4b5e7 View commit details
    Browse the repository at this point in the history

  16. [Fix] #289 - 하단 수정 완료 버튼 활성화 조건 변경 

    원래 값과 메뉴 이름 또는 가격이 다를 때에만 활성화 되도록
    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    be56afe View commit details
    Browse the repository at this point in the history

  17. [Fix] #289 - 키보드 위의 수정 완료 버튼도 활성화 조건 변경

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0913b53 View commit details
    Browse the repository at this point in the history

  18. [Chore] #289 - 마지막 메뉴 삭제 시 Alert 문구 변경

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d89f17e View commit details
    Browse the repository at this point in the history

  19. [Fix] #289 - 메뉴 추가 화면 상단 네비바 설정

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    40a2bfb View commit details
    Browse the repository at this point in the history

  20. [Fix] #289 - 메뉴 편집 바텀시트에서 네비바 제거

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d5fe41b View commit details
    Browse the repository at this point in the history

  21. [Fix] #289 - 기존 메뉴 값 입력 버튼 클릭 시 수정 완료 비활성화

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3ba7a77 View commit details
    Browse the repository at this point in the history

  22. [Fix] #289 - 키보드 위 수정 완료 버튼 기능 비활성화 로직 추가

    @EunsuSeo01
    EunsuSeo01 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d76cbf3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. [Chore] #289 - 안 쓰는 폴더 삭제

    @EunsuSeo01
    EunsuSeo01 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    0dc5708 View commit details
    Browse the repository at this point in the history

  2. [Chore] #289 - final 키워드 빠진 부분 추가

    @EunsuSeo01
    EunsuSeo01 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    41d67d4 View commit details
    Browse the repository at this point in the history

  3. [Refactor] #289 - storeId 위치 VC에서 VM으로 

    데이터는 VM이 관리
    @EunsuSeo01
    EunsuSeo01 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    ce56dc3 View commit details
    Browse the repository at this point in the history

  4. [Chore] #289 - 파라미터명과 함수명 변경

    @EunsuSeo01
    EunsuSeo01 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    2faca07 View commit details
    Browse the repository at this point in the history

  5. [Refactor] #289 - 프로토콜 분리 

    하나의 프로토콜에 있던 함수 2개를 각각의 프로토콜로 분리했다
AddVC에서는 원래 프로토콜의 함수 중 1개의 함수만 사용했기 때문이다
    @EunsuSeo01
    EunsuSeo01 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    e9b57d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. [Fix] #289 - return 키 클릭 시 키보드 내리기

    @EunsuSeo01
    EunsuSeo01 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    f6b303f View commit details
    Browse the repository at this point in the history

  2. [Feat] #289 - 수정 시 메뉴 이름 최대 30자 제한 걸기

    @EunsuSeo01
    EunsuSeo01 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    04eeb3c View commit details
    Browse the repository at this point in the history

  3. [Feat] #289 - 편집 화면에서 메뉴 이름 길 때 잘리도록 레이아웃 설정

    @EunsuSeo01
    EunsuSeo01 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    4c4506c View commit details
    Browse the repository at this point in the history

  4. [Feat] #289 - 수정 화면에서 메뉴 이름 30자일 때에도 전부 보이도록 레이아웃 설정

    @EunsuSeo01
    EunsuSeo01 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    85f1b48 View commit details
    Browse the repository at this point in the history

  5. [Refactor] #289 - 텍스트필드 활성화 로직 개선 

    로직을 간소화 하고 알아보기 쉽게 동작마다 함수로 분
    @EunsuSeo01
    EunsuSeo01 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    af62f96 View commit details
    Browse the repository at this point in the history

  6. [Refactor] #289 - 메뉴 추가 셀 스타일 변경 함수 개선

    @EunsuSeo01
    EunsuSeo01 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    ebdcc71 View commit details
    Browse the repository at this point in the history