Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge: (#78) 이메일 인증 정책 설계 #82

Merged
merged 41 commits into from
Sep 30, 2022
Merged

merge: (#78) 이메일 인증 정책 설계 #82

merged 41 commits into from
Sep 30, 2022

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Sep 25, 2022 •
edited
Loading

작업 내용 설명

  • AuthCode Domain Model 설계
  • AuthCode & AuthCodeLimit 영속성 관리 설계
  • 이메일 인증 API 구현
  • 이메일 인증 예외 처리
  • 이메일 인증 Port 설계

주요 변경 사항

  • UserSecurityPort javadoc 오타 수정
  • AuthCodeLimitEntity 생성자 수정
  • mockito-kotlin 의존성 추가
  • @default MapStruct 생성자 지정 어노테이션 추가

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Sep 25, 2022
@khcho0125 khcho0125 self-assigned this Sep 25, 2022
@codecov
Copy link

codecov bot commented Sep 25, 2022 •
edited
Loading

Codecov Report

Merging #82 (244f028) into main (4439a44) will increase coverage by 3.72%.
The diff coverage is 62.13%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #82      +/-   ##
============================================
+ Coverage     29.34%   33.06%   +3.72%     
- Complexity      104      124      +20     
============================================
  Files           100      111      +11     
  Lines           777      877     +100     
  Branches         17       19       +2     
============================================
+ Hits            228      290      +62     
- Misses          546      584      +38     
  Partials          3        3
Impacted Files Coverage Δ
...am/comit/simtong/global/aop/GlobalComponentScan.kt 0.00% <ø> (ø)
...team/comit/simtong/global/error/WebErrorHandler.kt 0.00% <0.00%> (ø)
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...ersistence/auth/AuthCodeLimitPersistenceAdapter.kt 0.00% <0.00%> (ø)
...ong/persistence/auth/AuthCodePersistenceAdapter.kt 0.00% <0.00%> (ø)
...ong/persistence/auth/entity/AuthCodeLimitEntity.kt 0.00% <0.00%> (ø)
.../simtong/persistence/auth/mapper/AuthCodeMapper.kt 0.00% <0.00%> (ø)
...kotlin/team/comit/simtong/email/WebEmailAdapter.kt 0.00% <0.00%> (ø)
...mtong/email/dto/request/WebCheckAuthCodeRequest.kt 0.00% <0.00%> (ø)
...imtong/email/dto/request/WebSendAuthCodeRequest.kt 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4439a44...244f028. Read the comment docs.

softpeanut
softpeanut reviewed Sep 26, 2022
View reviewed changes
...g-application/src/main/kotlin/team/comit/simtong/domain/auth/spi/CommandAuthCodeLimitPort.kt Show resolved Hide resolved
simtong-domain/src/main/kotlin/team/comit/simtong/domain/auth/model/AuthCode.kt Show resolved Hide resolved
simtong-domain/src/main/kotlin/team/comit/simtong/domain/auth/model/AuthCodeLimit.kt Outdated Show resolved Hide resolved
simtong-domain/src/main/kotlin/team/comit/simtong/domain/auth/policy/CheckAuthCodePolicy.kt Outdated Show resolved Hide resolved
simtong-domain/src/main/kotlin/team/comit/simtong/domain/auth/policy/SendAuthCodePolicy.kt Outdated Show resolved Hide resolved
simtong-domain/src/main/kotlin/team/comit/simtong/domain/auth/policy/SendAuthCodePolicy.kt Outdated Show resolved Hide resolved
simtong-infrastructure/src/main/kotlin/team/comit/simtong/global/error/WebErrorHandler.kt Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

softpeanut
softpeanut approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@khcho0125
Copy link
Member Author

khcho0125 commented Sep 30, 2022 •
edited
Loading

수고하셨습니다 👍

수고하셨어요...

@khcho0125 khcho0125 merged commit 4129163 into main Sep 30, 2022
@khcho0125 khcho0125 deleted the feature/78-email-policy branch September 30, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softpeanut softpeanut softpeanut approved these changes

Assignees

@khcho0125 khcho0125

Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

이메일 정책 시스템 설계
2 participants
@khcho0125 @softpeanut