Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge: (#54) 사원 번호 찾기 #56

Merged
merged 24 commits into from
Sep 17, 2022
Merged

merge: (#54) 사원 번호 찾기 #56

merged 24 commits into from
Sep 17, 2022

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Sep 11, 2022 •
edited
Loading

작업 내용 설명

  • FindEmployeeNumber 기능 구현
  • Web Common Adapter 추가

주요 변경 사항

  • TestCase 패키지 수정
  • User Persistence Repository 패키지 추가

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Sep 11, 2022
@khcho0125 khcho0125 self-assigned this Sep 11, 2022
@khcho0125 khcho0125 linked an issue Sep 11, 2022 that may be closed by this pull request
사원 번호 찾기 설계 #54
Closed
@codecov
Copy link

codecov bot commented Sep 11, 2022 •
edited
Loading

Codecov Report

Merging #56 (15bed41) into main (658c0c9) will increase coverage by 0.58%.
The diff coverage is 32.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #56      +/-   ##
============================================
+ Coverage     22.18%   22.76%   +0.58%     
- Complexity       58       66       +8     
============================================
  Files            67       72       +5     
  Lines           541      571      +30     
  Branches         14       14              
============================================
+ Hits            120      130      +10     
- Misses          419      439      +20     
  Partials          2        2
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...ng/global/security/principle/AuthDetailsService.kt 0.00% <ø> (ø)
...simtong/persistence/user/UserPersistenceAdapter.kt 0.00% <0.00%> (ø)
...am/comit/simtong/domain/common/WebCommonAdapter.kt 0.00% <0.00%> (ø)
...common/dto/request/WebFindEmployeeNumberRequest.kt 0.00% <0.00%> (ø)
...mmon/dto/response/WebFindEmployeeNumberResponse.kt 0.00% <0.00%> (ø)
...imtong/domain/user/dto/request/WebSignUpRequest.kt 0.00% <0.00%> (ø)
...g/domain/user/usecase/FindEmployeeNumberUseCase.kt 100.00% <100.00%> (ø)
...main/user/usecase/dto/FindEmployeeNumberRequest.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 658c0c9...15bed41. Read the comment docs.

@khcho0125 khcho0125 mentioned this pull request Sep 11, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit a5e83cf into main Sep 17, 2022
@khcho0125 khcho0125 deleted the feature/54-find-the-employee-number branch September 17, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softpeanut softpeanut softpeanut approved these changes

Assignees

@khcho0125 khcho0125

Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

사원 번호 찾기 설계
2 participants
@khcho0125 @softpeanut