Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#34) 회원가입 정책 설계 #49

Merged
merged 30 commits into from
Sep 14, 2022

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Sep 9, 2022

작업 내용 설명

  • SignUpPolicy
  • SignUp TestCase
  • SignUpPolicy Port
  • AuthCodePolicy

주요 변경 사항

  • AuthCodePolicy의 도메인 모델 설계
  • SignUpPolicy의 Port를 구현
  • 외부 로직을 도메인 계층에서 제거
  • DomainQueryUserPort 추가

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Sep 9, 2022
@khcho0125 khcho0125 self-assigned this Sep 9, 2022
@khcho0125 khcho0125 linked an issue Sep 9, 2022 that may be closed by this pull request
1 task
@khcho0125 khcho0125 changed the title merge: (#34) merge: (#34) 회원가입 테스트 설계 Sep 9, 2022
@khcho0125 khcho0125 added the test 테스트를 추가 할 경우 label Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #49 (cc06e4d) into main (0692868) will increase coverage by 7.53%.
The diff coverage is 65.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #49      +/-   ##
============================================
+ Coverage     14.00%   21.54%   +7.53%     
- Complexity       33       54      +21     
============================================
  Files            63       68       +5     
  Lines           514      543      +29     
  Branches         12       14       +2     
============================================
+ Hits             72      117      +45     
+ Misses          442      423      -19     
- Partials          0        3       +3     
Impacted Files Coverage Δ
...imtong/global/security/token/GenerateJwtAdapter.kt 0.00% <ø> (ø)
.../simtong/persistence/auth/AuthCodePolicyAdapter.kt 0.00% <0.00%> (ø)
...ng/persistence/auth/mapper/AuthCodePolicyMapper.kt 0.00% <0.00%> (ø)
...simtong/persistence/user/UserPersistenceAdapter.kt 0.00% <ø> (ø)
...m/comit/simtong/domain/auth/error/AuthErrorCode.kt 71.42% <71.42%> (ø)
...m/comit/simtong/domain/user/policy/SignUpPolicy.kt 83.33% <85.71%> (+83.33%) ⬆️
...domain/auth/exception/UncertifiedEmailException.kt 100.00% <100.00%> (ø)
...imtong/domain/auth/exception/UsedEmailException.kt 100.00% <100.00%> (ø)
.../comit/simtong/domain/auth/model/AuthCodePolicy.kt 100.00% <100.00%> (ø)
...m/comit/simtong/domain/user/error/UserErrorCode.kt 71.42% <100.00%> (-3.58%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0692868...cc06e4d. Read the comment docs.

@softpeanut
Copy link
Member

변경사항에 따라 PR의 작업 내용 및 주요 변경 사항을 상세하게 적어주시면 좋을 것 같습니다.

@khcho0125 khcho0125 changed the title merge: (#34) 회원가입 테스트 설계 merge: (#34) 회원가입 정책 설계 Sep 11, 2022
@khcho0125 khcho0125 removed a link to an issue Sep 11, 2022
1 task
@khcho0125 khcho0125 linked an issue Sep 11, 2022 that may be closed by this pull request
@khcho0125 khcho0125 removed a link to an issue Sep 11, 2022
@khcho0125 khcho0125 linked an issue Sep 11, 2022 that may be closed by this pull request
1 task
@khcho0125 khcho0125 mentioned this pull request Sep 12, 2022
@khcho0125 khcho0125 closed this Sep 12, 2022
@khcho0125 khcho0125 deleted the feature/34-create-signup-testcase branch September 12, 2022 07:34
@khcho0125 khcho0125 restored the feature/34-create-signup-testcase branch September 12, 2022 07:35
@khcho0125 khcho0125 deleted the feature/34-create-signup-testcase branch September 12, 2022 07:36
@khcho0125 khcho0125 restored the feature/34-create-signup-testcase branch September 12, 2022 07:37
@khcho0125 khcho0125 reopened this Sep 12, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit c09d651 into main Sep 14, 2022
@khcho0125 khcho0125 deleted the feature/34-create-signup-testcase branch September 14, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우 test 테스트를 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

회원 가입 정책 설계
2 participants