Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#26) ErrorResponse 형식 #40

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Conversation

softpeanut
Copy link
Member

작업 내용 설명

  • CustomFieldError 추가

주요 변경 사항

  • ErrorResponse에 CustomFieldError 적용
  • ConstraintViolationException ErrorResponse 메서드 호출시 인자로 exception 전달

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added bug 버그가 발생한 경우 refactor 코드 리팩토링 할 경우 labels Sep 7, 2022
@softpeanut softpeanut self-assigned this Sep 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #40 (7f72461) into main (f55ea24) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #40   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         49      50    +1     
  Lines        409     429   +20     
  Branches      10      11    +1     
=====================================
- Misses       409     429   +20     
Impacted Files Coverage Δ
...eam/comit/simtong/global/error/CustomFieldError.kt 0.00% <0.00%> (ø)
...n/team/comit/simtong/global/error/ErrorResponse.kt 0.00% <0.00%> (ø)
...team/comit/simtong/global/error/WebErrorHandler.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55ea24...7f72461. Read the comment docs.

@softpeanut softpeanut merged commit efd6f24 into main Sep 7, 2022
@softpeanut softpeanut deleted the bug/26-error-response branch September 7, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 버그가 발생한 경우 refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Response 양식 수정
3 participants