Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#28) User 설계 오류 수정 #39

Merged
merged 5 commits into from
Sep 7, 2022
Merged

Conversation

softpeanut
Copy link
Member

작업 내용 설명

  • User Entity UUID 문제

주요 변경 사항

  • User Aggregate의 id non-null
  • BaseEntity, BaseUUIDEntity의 UUID 생성 방식
  • BaseTimeEntity의 createdAt 컬럼 수정 방지

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added bug 버그가 발생한 경우 refactor 코드 리팩토링 할 경우 labels Sep 7, 2022
@softpeanut softpeanut self-assigned this Sep 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #39 (67bd1a0) into main (f55ea24) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #39   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         49      49           
  Lines        409     410    +1     
  Branches      10      10           
=====================================
- Misses       409     410    +1     
Impacted Files Coverage Δ
...comit/simtong/domain/user/usecase/SignUpUseCase.kt 0.00% <0.00%> (ø)
...otlin/team/comit/simtong/domain/user/model/User.kt 0.00% <0.00%> (ø)
...m/comit/simtong/domain/user/policy/SignUpPolicy.kt 0.00% <ø> (ø)
...otlin/team/comit/simtong/persistence/BaseEntity.kt 0.00% <0.00%> (ø)
...n/team/comit/simtong/persistence/BaseTimeEntity.kt 0.00% <0.00%> (ø)
...n/team/comit/simtong/persistence/BaseUUIDEntity.kt 0.00% <0.00%> (ø)
...t/simtong/persistence/spot/entity/SpotJpaEntity.kt 0.00% <0.00%> (ø)
...t/simtong/persistence/team/entity/TeamJpaEntity.kt 0.00% <0.00%> (ø)
...t/simtong/persistence/user/entity/UserJpaEntity.kt 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55ea24...67bd1a0. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@softpeanut softpeanut merged commit 0522a43 into main Sep 7, 2022
@softpeanut softpeanut deleted the bug/28-user-entity branch September 7, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 버그가 발생한 경우 refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User 설계 오류 수정
3 participants