Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#287) Value Class 오류 수정 #288

Merged
merged 3 commits into from
Jan 8, 2023
Merged

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Jan 8, 2023

작업 내용 설명

  • value class 오류 수정

주요 변경 사항

  • ModelAttribute → RequestParam 변경

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the bug 버그가 발생한 경우 label Jan 8, 2023
@khcho0125 khcho0125 self-assigned this Jan 8, 2023
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #288 (8783b16) into develop (3163002) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #288      +/-   ##
=============================================
+ Coverage      41.35%   41.43%   +0.08%     
  Complexity       354      354              
=============================================
  Files            237      236       -1     
  Lines           2563     2558       -5     
  Branches         106      106              
=============================================
  Hits            1060     1060              
+ Misses          1499     1494       -5     
  Partials           4        4              
Impacted Files Coverage Δ
...am/comit/simtong/domain/common/WebCommonAdapter.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3163002...8783b16. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit 79f5efb into develop Jan 8, 2023
@khcho0125 khcho0125 deleted the fix/287-value-clas-error branch January 8, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 버그가 발생한 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants