Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#275) Index 설정 #276

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

softpeanut
Copy link
Member

작업 내용 설명

  • UserJpaEntity에 employeeNumber, email, nickname index 추가
  • ScheduleJpaEntity에 startAt, endAt index 추가
  • EmployeeCertificateJpaEntity에 name index 추가

주요 변경 사항

  • 없음

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the performance 성능을 개선 할 경우 label Jan 4, 2023
@softpeanut softpeanut self-assigned this Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #276 (ff89a8b) into develop (118bd9a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #276   +/-   ##
==========================================
  Coverage      41.48%   41.48%           
  Complexity       354      354           
==========================================
  Files            234      234           
  Lines           2555     2555           
  Branches         103      103           
==========================================
  Hits            1060     1060           
  Misses          1491     1491           
  Partials           4        4           
Impacted Files Coverage Δ
...stence/file/entity/EmployeeCertificateJpaEntity.kt 0.00% <ø> (ø)
...g/persistence/schedule/entity/ScheduleJpaEntity.kt 0.00% <ø> (ø)
...t/simtong/persistence/user/entity/UserJpaEntity.kt 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118bd9a...ff89a8b. Read the comment docs.

khcho0125
khcho0125 previously approved these changes Jan 4, 2023
@khcho0125 khcho0125 self-requested a review January 4, 2023 03:32
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@softpeanut softpeanut merged commit 379f43b into develop Jan 4, 2023
@softpeanut softpeanut deleted the performance/275-database-index branch January 4, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance 성능을 개선 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants