Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge: (#264) 디바이스 토큰 저장 #266

Merged
merged 7 commits into from
Jan 2, 2023
Merged

merge: (#264) 디바이스 토큰 저장 #266

merged 7 commits into from
Jan 2, 2023

Conversation

softpeanut
Copy link
Member

작업 내용 설명

  • SignInUseCase, SignUpUseCase 로직에 디바이스 토큰 저장 로직 추가
  • DeviceToken Aggregate
  • DeviceTokenMapper
  • CommandDeviceTokenPort

주요 변경 사항

  • POST /notifications, /notifications/list permission
  • 관리자, 일반 사용자 SignInWebRequest, SignInRequest 분리
  • stage 환경 -> dev 환경

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added feat 새로운 기능을 추가 할 경우 refactor 코드 리팩토링 할 경우 labels Jan 2, 2023
@softpeanut softpeanut self-assigned this Jan 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

khcho0125
khcho0125 approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@softpeanut softpeanut merged commit 0ff4cb4 into develop Jan 2, 2023
@softpeanut softpeanut deleted the feature/264-save-device-token branch January 2, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khcho0125 khcho0125 khcho0125 approved these changes

Assignees

@softpeanut softpeanut

Labels
feat 새로운 기능을 추가 할 경우 refactor 코드 리팩토링 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@softpeanut @khcho0125