Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#264) 디바이스 토큰 저장 #265

Closed
wants to merge 7 commits into from

Conversation

softpeanut
Copy link
Member

작업 내용 설명

  • SignInUseCase, SignUpUseCase 로직에 디바이스 토큰 저장 로직 추가
  • DeviceToken Aggregate
  • DeviceTokenMapper
  • CommandDeviceTokenPort

주요 변경 사항

  • POST /notifications, /notifications/list permission
  • 관리자, 일반 사용자 SignInWebRequest, SignInRequest 분리

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the feat 새로운 기능을 추가 할 경우 label Jan 1, 2023
@softpeanut softpeanut self-assigned this Jan 1, 2023
@codecov
Copy link

codecov bot commented Jan 1, 2023

Codecov Report

Merging #265 (d0d8b9b) into main (3a31291) will increase coverage by 0.08%.
The diff coverage is 46.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #265      +/-   ##
============================================
+ Coverage     41.43%   41.51%   +0.08%     
- Complexity      350      356       +6     
============================================
  Files           230      234       +4     
  Lines          2515     2553      +38     
  Branches        104      104              
============================================
+ Hits           1042     1060      +18     
- Misses         1469     1489      +20     
  Partials          4        4              
Impacted Files Coverage Δ
.../simtong/domain/user/usecase/AdminSignInUseCase.kt 100.00% <ø> (ø)
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...simtong/persistence/user/UserPersistenceAdapter.kt 0.00% <0.00%> (ø)
...mtong/persistence/user/mapper/DeviceTokenMapper.kt 0.00% <0.00%> (ø)
...team/comit/simtong/domain/admin/WebAdminAdapter.kt 0.00% <0.00%> (ø)
...mtong/domain/admin/dto/request/SignInWebRequest.kt 0.00% <0.00%> (ø)
...n/team/comit/simtong/domain/user/WebUserAdapter.kt 0.00% <0.00%> (ø)
...imtong/domain/user/dto/request/SignInWebRequest.kt 0.00% <0.00%> (ø)
...imtong/domain/user/dto/request/SignUpWebRequest.kt 0.00% <0.00%> (ø)
...omit/simtong/domain/user/dto/AdminSignInRequest.kt 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a31291...d0d8b9b. Read the comment docs.

khcho0125
khcho0125 previously approved these changes Jan 2, 2023
Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@softpeanut softpeanut deleted the feature/264-save-device-token branch January 2, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

회원가입, 로그인 시 디바이스 토큰 받기
2 participants