Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#260) Notification Model 설계 #262

Merged
merged 13 commits into from
Dec 30, 2022

Conversation

softpeanut
Copy link
Member

@softpeanut softpeanut commented Dec 29, 2022

작업 내용 설명

  • Notification JpaEntity, Mapper, JpaRepository, Aggregate model
  • NotificationReceiver JpaEntity, Mapper, JpaRepository, Aggregate model
  • NotificationExceptions

주요 변경 사항

  • 없음

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut self-assigned this Dec 29, 2022
@softpeanut softpeanut added the feat 새로운 기능을 추가 할 경우 label Dec 29, 2022
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #262 (104d758) into main (d1976c0) will decrease coverage by 0.96%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #262      +/-   ##
============================================
- Coverage     44.02%   43.05%   -0.97%     
  Complexity      350      350              
============================================
  Files           217      225       +8     
  Lines          2367     2420      +53     
  Branches        104      104              
============================================
  Hits           1042     1042              
- Misses         1321     1374      +53     
  Partials          4        4              
Impacted Files Coverage Δ
...n/notification/exception/NotificationExceptions.kt 0.00% <0.00%> (ø)
.../simtong/domain/notification/model/Notification.kt 0.00% <0.00%> (ø)
.../domain/notification/model/NotificationReceiver.kt 0.00% <0.00%> (ø)
...tong/domain/notification/model/NotificationType.kt 0.00% <0.00%> (ø)
...tence/notification/entity/NotificationJpaEntity.kt 0.00% <0.00%> (ø)
...tification/entity/NotificationReceiverJpaEntity.kt 0.00% <0.00%> (ø)
...sistence/notification/mapper/NotificationMapper.kt 0.00% <0.00%> (ø)
.../notification/mapper/NotificationReceiverMapper.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1976c0...104d758. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125
Copy link
Member

LGTM 👍

@softpeanut softpeanut merged commit 0550c90 into main Dec 30, 2022
@softpeanut softpeanut deleted the feature/260-notification-model branch December 30, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification Model 설계
2 participants