Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#253) 지점 직원 휴무일 변경 #257

Merged
merged 5 commits into from
Dec 23, 2022

Conversation

softpeanut
Copy link
Member

@softpeanut softpeanut commented Dec 23, 2022

작업 내용 설명

  • ChangeEmployeeHolidayUseCase

주요 변경 사항

  • 지점 직원 휴무일 변경 API permission

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the feat 새로운 기능을 추가 할 경우 label Dec 23, 2022
@softpeanut softpeanut self-assigned this Dec 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #257 (67b0124) into main (8bd0240) will increase coverage by 0.24%.
The diff coverage is 61.29%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #257      +/-   ##
============================================
+ Coverage     44.67%   44.91%   +0.24%     
- Complexity      343      350       +7     
============================================
  Files           213      215       +2     
  Lines          2290     2320      +30     
  Branches         99      103       +4     
============================================
+ Hits           1023     1042      +19     
- Misses         1263     1274      +11     
  Partials          4        4              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
.../comit/simtong/domain/holiday/WebHolidayAdapter.kt 0.00% <0.00%> (ø)
...day/dto/request/ChangeEmployeeHolidayWebRequest.kt 0.00% <0.00%> (ø)
...in/holiday/usecase/ChangeEmployeeHolidayUseCase.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd0240...67b0124. Read the comment docs.

Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@softpeanut softpeanut merged commit 01c7c42 into main Dec 23, 2022
@softpeanut softpeanut deleted the feature/253-update-employee-holiday-api branch December 23, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

지점 직원 휴무일 변경 API
2 participants