Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#251) 휴무표 작성 기간 설정 기능 #254

Merged
merged 8 commits into from
Dec 23, 2022

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • 휴무표 작성 기간 설정 UseCase

주요 변경 사항

  • 휴무표 작성 기간 저장 쿼리 추가
  • CancelHolidayRequest → CancelHolidayWebRequest

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Dec 22, 2022
@khcho0125 khcho0125 self-assigned this Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #254 (fc673eb) into main (34896b0) will increase coverage by 0.12%.
The diff coverage is 51.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #254      +/-   ##
============================================
+ Coverage     44.24%   44.36%   +0.12%     
- Complexity      330      338       +8     
============================================
  Files           208      211       +3     
  Lines          2233     2272      +39     
  Branches         98       98              
============================================
+ Hits            988     1008      +20     
- Misses         1241     1260      +19     
  Partials          4        4              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...istence/holiday/HolidayPeriodPersistenceAdapter.kt 0.00% <0.00%> (ø)
.../comit/simtong/domain/holiday/WebHolidayAdapter.kt 0.00% <0.00%> (ø)
...iday/dto/request/AppointHolidayPeriodWebRequest.kt 0.00% <0.00%> (ø)
...ain/holiday/dto/request/CancelHolidayWebRequest.kt 0.00% <0.00%> (ø)
.../domain/holiday/dto/AppointHolidayPeriodRequest.kt 100.00% <100.00%> (ø)
...ain/holiday/usecase/AppointHolidayPeriodUseCase.kt 100.00% <100.00%> (ø)
...ng/domain/holiday/usecase/AppointHolidayUseCase.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34896b0...fc673eb. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khcho0125 khcho0125 merged commit 50e819a into main Dec 23, 2022
@khcho0125 khcho0125 deleted the feature/251-appoint-holiday-creation-period branch December 23, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

휴무표 작성 기간 설정 기능
2 participants