Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#249) 휴무표 작성 기간 확인 기능 #250

Merged
merged 8 commits into from
Dec 22, 2022

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • 휴무표 작성 기간 확인 UseCase

주요 변경 사항

  • HolidayEntity HolidayStatus 컬럼 속성 값 변경

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Dec 22, 2022
@khcho0125 khcho0125 self-assigned this Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #250 (f8c6085) into main (2c3edfe) will increase coverage by 0.03%.
The diff coverage is 45.45%.

❗ Current head f8c6085 differs from pull request most recent head 0720d2a. Consider uploading reports for the commit 0720d2a to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #250      +/-   ##
============================================
+ Coverage     44.21%   44.24%   +0.03%     
- Complexity      326      330       +4     
============================================
  Files           207      208       +1     
  Lines          2212     2233      +21     
  Branches         96       98       +2     
============================================
+ Hits            978      988      +10     
- Misses         1230     1241      +11     
  Partials          4        4              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...istence/holiday/HolidayPeriodPersistenceAdapter.kt 0.00% <0.00%> (ø)
...ong/persistence/holiday/entity/HolidayJpaEntity.kt 0.00% <ø> (ø)
.../comit/simtong/domain/holiday/WebHolidayAdapter.kt 0.00% <0.00%> (ø)
...omain/holiday/usecase/CheckHolidayPeriodUseCase.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3edfe...0720d2a. Read the comment docs.

softpeanut
softpeanut previously approved these changes Dec 22, 2022
Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit 34896b0 into main Dec 22, 2022
@khcho0125 khcho0125 deleted the feature/249-check-holiday-creation-period branch December 22, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

휴무일 작성 기간 확인 기능
2 participants