Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#228) 회원가입시 사원번호 검사 추가 #229

Merged
merged 6 commits into from
Dec 17, 2022

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • 사원번호 Query 추가
  • 테스트 케이스 변경 및 추가

주요 변경 사항

  • 이미 사용중인 사원번호 예외 추가

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the refactor 코드 리팩토링 할 경우 label Dec 17, 2022
@khcho0125 khcho0125 self-assigned this Dec 17, 2022
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #229 (7bc1981) into main (07e6237) will increase coverage by 0.15%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #229      +/-   ##
============================================
+ Coverage     42.91%   43.07%   +0.15%     
- Complexity      276      279       +3     
============================================
  Files           185      185              
  Lines          1899     1906       +7     
  Branches         77       79       +2     
============================================
+ Hits            815      821       +6     
- Misses         1082     1083       +1     
  Partials          2        2              
Impacted Files Coverage Δ
...simtong/persistence/user/UserPersistenceAdapter.kt 0.00% <0.00%> (ø)
...comit/simtong/domain/user/usecase/SignUpUseCase.kt 100.00% <100.00%> (ø)
...it/simtong/domain/auth/exception/AuthExceptions.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e6237...7bc1981. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khcho0125 khcho0125 merged commit fa5689c into main Dec 17, 2022
@khcho0125 khcho0125 deleted the refactor/228-check-employee-number branch December 17, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

회원가입시 사원번호 중복 확인
2 participants