Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#204) 지점 + 개인 일정 보기 변경사항 #206

Merged
merged 3 commits into from
Dec 10, 2022

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • 지점, 개인 일정 구분 필드 추가
  • 지점 전체 일정이 아닌 지점의 개인 일정을 가져오는 오류 수정

주요 변경 사항

  • List 병합 작업 union 대신 plus

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added bug 버그가 발생한 경우 refactor 코드 리팩토링 할 경우 labels Dec 10, 2022
@khcho0125 khcho0125 self-assigned this Dec 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #206 (4de3ec7) into main (798c0dc) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #206      +/-   ##
============================================
+ Coverage     42.83%   42.89%   +0.06%     
  Complexity      315      315              
============================================
  Files           211      211              
  Lines          1877     1879       +2     
  Branches         71       71              
============================================
+ Hits            804      806       +2     
  Misses         1070     1070              
  Partials          3        3              
Impacted Files Coverage Δ
...chedule/dto/QueryIndividualSpotScheduleResponse.kt 100.00% <100.00%> (ø)
...dule/usecase/QueryIndividualSpotScheduleUseCase.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 798c0dc...4de3ec7. Read the comment docs.

@khcho0125 khcho0125 merged commit 91ea254 into main Dec 10, 2022
@khcho0125 khcho0125 deleted the refactor/204-spot-and-individual-schedule branch December 10, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 버그가 발생한 경우 refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

지점 + 개인 일정 보기 Response 변경사항
2 participants