Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#202) MultipartFile → File 변환 리팩토링 #203

Merged
merged 8 commits into from
Dec 10, 2022

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Dec 9, 2022

작업 내용 설명

  • MultipartFile → File 변환 전 파일 확장자 체크

주요 변경 사항

  • Presentation 계층 Web Error 설정
  • 파일 확장자 제한 예외 계층 이동
  • File Convertor 추가
  • 기존 파일 확장자 확인 로직 제거

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added performance 성능을 개선 할 경우 refactor 코드 리팩토링 할 경우 labels Dec 9, 2022
@khcho0125 khcho0125 added this to the 2차 기능 마감 milestone Dec 9, 2022
@khcho0125 khcho0125 self-assigned this Dec 9, 2022
softpeanut
softpeanut previously approved these changes Dec 9, 2022
@khcho0125 khcho0125 removed this from the 2차 기능 마감 milestone Dec 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #203 (a80ba42) into main (30dff4c) will decrease coverage by 1.64%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #203      +/-   ##
============================================
- Coverage     44.39%   42.74%   -1.65%     
+ Complexity      324      315       -9     
============================================
  Files           207      212       +5     
  Lines          1845     1881      +36     
  Branches         67       71       +4     
============================================
- Hits            819      804      -15     
- Misses         1022     1074      +52     
+ Partials          4        3       -1     
Impacted Files Coverage Δ
...am/comit/simtong/domain/file/FileExtensionUtils.kt 0.00% <ø> (ø)
.../simtong/domain/file/usecase/UploadImageUseCase.kt 100.00% <ø> (ø)
...m/comit/simtong/domain/file/error/FileErrorCode.kt 77.77% <ø> (-2.23%) ⬇️
...am/comit/simtong/global/error/dto/ErrorResponse.kt 0.00% <0.00%> (ø)
...eam/comit/simtong/global/filter/ExceptionFilter.kt 0.00% <0.00%> (ø)
...n/team/comit/simtong/domain/file/WebFileAdapter.kt 0.00% <0.00%> (ø)
...omit/simtong/domain/file/error/WebFileErrorCode.kt 0.00% <0.00%> (ø)
...in/file/exception/FileInvalidExtensionException.kt 0.00% <0.00%> (ø)
...simtong/domain/file/transfer/ExcelFileConvertor.kt 0.00% <0.00%> (ø)
...omit/simtong/domain/file/transfer/FileConvertor.kt 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30dff4c...a80ba42. Read the comment docs.

@khcho0125 khcho0125 merged commit 4235884 into main Dec 10, 2022
@khcho0125 khcho0125 deleted the refactor/202-file-convertor branch December 10, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance 성능을 개선 할 경우 refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultipartFile → File 변환 리팩토링
2 participants