Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#196) Aggregate Mapping 코드 스타일 변경 #198

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • Enitty → Domain Model 변환 코드 스타일 변경

주요 변경 사항

  • equals(=) 대신 return 사용
  • 반환 타입 명시

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the refactor 코드 리팩토링 할 경우 label Dec 8, 2022
@khcho0125 khcho0125 added this to the 2차 기능 마감 milestone Dec 8, 2022
@khcho0125 khcho0125 self-assigned this Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #198 (89db5f3) into main (cc06534) will increase coverage by 0.52%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #198      +/-   ##
============================================
+ Coverage     43.58%   44.11%   +0.52%     
  Complexity      323      323              
============================================
  Files           207      207              
  Lines          1856     1834      -22     
  Branches         65       65              
============================================
  Hits            809      809              
+ Misses         1044     1022      -22     
  Partials          3        3              
Impacted Files Coverage Δ
...ersistence/auth/AuthCodeLimitPersistenceAdapter.kt 0.00% <0.00%> (ø)
...ong/persistence/auth/AuthCodePersistenceAdapter.kt 0.00% <0.00%> (ø)
...persistence/auth/RefreshTokenPersistenceAdapter.kt 0.00% <0.00%> (ø)
...ence/file/EmployeeCertificatePersistenceAdapter.kt 0.00% <0.00%> (ø)
...g/persistence/holiday/HolidayPersistenceAdapter.kt 0.00% <0.00%> (ø)
...persistence/schedule/SchedulePersistenceAdapter.kt 0.00% <0.00%> (ø)
...simtong/persistence/spot/SpotPersistenceAdapter.kt 0.00% <0.00%> (ø)
...simtong/persistence/team/TeamPersistenceAdapter.kt 0.00% <0.00%> (ø)
...simtong/persistence/user/UserPersistenceAdapter.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc06534...89db5f3. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit dcb3b4b into main Dec 8, 2022
@khcho0125 khcho0125 deleted the refactor/196-mapping-code-style branch December 8, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
Development

Successfully merging this pull request may close these issues.

Entity 매핑 시 Code Style 변경
2 participants