Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#194) 회원가입 사원 정보 확인 #195

Merged
merged 6 commits into from
Dec 8, 2022

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Dec 7, 2022

작업 내용 설명

  • 회원가입 사원 정보 확인 로직 추가

주요 변경 사항

  • EmployeeCertificate 관련 누락된 javadoc 추가 및 javadoc 수정
  • NotFoundFilePath 예외 누락된 javadoc 추가

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added docs 문서가 추가되거나 변경되는 경우 refactor 코드 리팩토링 할 경우 labels Dec 7, 2022
@khcho0125 khcho0125 added this to the 2차 기능 마감 milestone Dec 7, 2022
@khcho0125 khcho0125 self-assigned this Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #195 (bc4cd9b) into main (2f06ef4) will increase coverage by 0.17%.
The diff coverage is 77.77%.

❗ Current head bc4cd9b differs from pull request most recent head c1f5321. Consider uploading reports for the commit c1f5321 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #195      +/-   ##
============================================
+ Coverage     43.90%   44.08%   +0.17%     
- Complexity      315      321       +6     
============================================
  Files           203      203              
  Lines          1806     1817      +11     
  Branches         60       61       +1     
============================================
+ Hits            793      801       +8     
- Misses         1010     1013       +3     
  Partials          3        3              
Impacted Files Coverage Δ
...domain/file/exception/NotFoundFilePathException.kt 100.00% <ø> (ø)
...ence/file/EmployeeCertificatePersistenceAdapter.kt 0.00% <0.00%> (ø)
...stence/file/entity/EmployeeCertificateJpaEntity.kt 0.00% <ø> (ø)
...rsistence/file/mapper/EmployeeCertificateMapper.kt 0.00% <ø> (ø)
...comit/simtong/domain/user/usecase/SignUpUseCase.kt 100.00% <100.00%> (ø)
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...n/team/comit/simtong/global/config/WebMvcConfig.kt
...am/comit/simtong/global/config/DateFormatConfig.kt 0.00% <0.00%> (ø)
...t/simtong/domain/file/model/EmployeeCertificate.kt 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f06ef4...c1f5321. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit b9b0356 into main Dec 8, 2022
@khcho0125 khcho0125 deleted the feature/194-signup-additional branch December 8, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 문서가 추가되거나 변경되는 경우 refactor 코드 리팩토링 할 경우
Projects
Development

Successfully merging this pull request may close these issues.

회원가입 기능 설계 추가 작업
2 participants