Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#191) 이름, 사원번호 일치 여부 확인 API #192

Merged
merged 8 commits into from
Dec 7, 2022

Conversation

softpeanut
Copy link
Member

@softpeanut softpeanut commented Dec 7, 2022

작업 내용 설명

  • CheckEmployeeUseCase

주요 변경 사항

  • 사원 확인 UseCase permission

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the feat 새로운 기능을 추가 할 경우 label Dec 7, 2022
@softpeanut softpeanut self-assigned this Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #192 (fcd6e8b) into main (729e694) will increase coverage by 0.22%.
The diff coverage is 64.70%.

❗ Current head fcd6e8b differs from pull request most recent head 06164fa. Consider uploading reports for the commit 06164fa to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #192      +/-   ##
============================================
+ Coverage     43.46%   43.69%   +0.22%     
- Complexity      310      314       +4     
============================================
  Files           202      204       +2     
  Lines          1799     1815      +16     
  Branches         59       60       +1     
============================================
+ Hits            782      793      +11     
- Misses         1014     1019       +5     
  Partials          3        3              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...ence/file/EmployeeCertificatePersistenceAdapter.kt 0.00% <0.00%> (ø)
...n/team/comit/simtong/domain/user/WebUserAdapter.kt 0.00% <0.00%> (ø)
...imtong/domain/file/usecase/CheckEmployeeUseCase.kt 100.00% <100.00%> (ø)
...m/comit/simtong/domain/file/error/FileErrorCode.kt 77.77% <100.00%> (+2.77%) ⬆️
.../domain/file/exception/InvalidEmployeeException.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729e694...06164fa. Read the comment docs.

@softpeanut softpeanut marked this pull request as ready for review December 7, 2022 13:36
@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@softpeanut softpeanut merged commit acc40ec into main Dec 7, 2022
@softpeanut softpeanut deleted the feature/191-compare-name-employee-number-api branch December 7, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

이름 - 사원번호 일치 여부 판별 API
2 participants