Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#174) 휴무일 또는 연차 취소 기능 #175

Merged
merged 5 commits into from
Dec 4, 2022

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • CancelHoliday UseCase 설계
  • CancelHoliday Domain Query 추가

주요 변경 사항

  • Security Config - DELETE, /work, ROLE_COMMON
  • Holiday Not Found Exception 추가

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Dec 4, 2022
@khcho0125 khcho0125 self-assigned this Dec 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Merging #175 (6476693) into main (116a957) will increase coverage by 0.02%.
The diff coverage is 43.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #175      +/-   ##
============================================
+ Coverage     43.63%   43.65%   +0.02%     
- Complexity      296      301       +5     
============================================
  Files           192      195       +3     
  Lines          1696     1725      +29     
  Branches         57       58       +1     
============================================
+ Hits            740      753      +13     
- Misses          953      969      +16     
  Partials          3        3              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...g/persistence/holiday/HolidayPersistenceAdapter.kt 0.00% <0.00%> (ø)
.../comit/simtong/domain/holiday/WebHolidayAdapter.kt 0.00% <0.00%> (ø)
...ain/holiday/dto/request/CancelHolidayWebRequest.kt 0.00% <0.00%> (ø)
...ong/domain/holiday/usecase/CancelHolidayUseCase.kt 100.00% <100.00%> (ø)
...t/simtong/domain/holiday/error/HolidayErrorCode.kt 71.42% <100.00%> (+4.76%) ⬆️
...main/holiday/exception/HolidayNotFoundException.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116a957...6476693. Read the comment docs.

@khcho0125 khcho0125 merged commit 8a6dd85 into main Dec 4, 2022
@khcho0125 khcho0125 deleted the feature/174-cancel-holiday branch December 4, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

휴무일/연차 취소 기능 설계
2 participants