Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#158) Domain Properties 초기화 전체 적용 #161

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • Domain Properties Initialization 모든 테스트 케이스 적용

주요 변경 사항

  • Domain Properties Initialization javadoc 삭제
  • Application 계층 Test Case Import Domain Properties Initialization

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added refactor 코드 리팩토링 할 경우 test 테스트를 추가 할 경우 labels Nov 28, 2022
@khcho0125 khcho0125 self-assigned this Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #161 (a7d0003) into main (fa90013) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #161   +/-   ##
=========================================
  Coverage     43.16%   43.16%           
  Complexity      272      272           
=========================================
  Files           175      175           
  Lines          1522     1522           
  Branches         51       51           
=========================================
  Hits            657      657           
  Misses          862      862           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa90013...a7d0003. Read the comment docs.

Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 테스트 코드에 달려있는 @import@ExtendWith를 사용한 어떠한 어노테이션을 제작하여서 그걸 사용해보면 좋을 것 같아요.
예를 들어서 @~~Test 라는 어노테이션을 만들고 그 어노테이션에 위의 2개의 어노테이션을 적용하면 좋을 것 같습니다.

@khcho0125
Copy link
Member Author

모든 테스트 코드에 달려있는 @import@ExtendWith를 사용한 어떠한 어노테이션을 제작하여서 그걸 사용해보면 좋을 것 같아요. 예를 들어서 @~~Test 라는 어노테이션을 만들고 그 어노테이션에 위의 2개의 어노테이션을 적용하면 좋을 것 같습니다.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit 9f700cd into main Nov 28, 2022
@khcho0125 khcho0125 deleted the refactor/158-test-domain-initialization branch November 28, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우 test 테스트를 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

전체 Test Case Domain 초기화 Import
2 participants