Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge: (#156) 개인 일정 변경 기능 설계 #157

Merged
merged 10 commits into from
Nov 27, 2022
Merged

merge: (#156) 개인 일정 변경 기능 설계 #157

merged 10 commits into from
Nov 27, 2022

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • 개인 일정 변경 UseCase 추가
  • 지점 일정 변경 - 지점 확인 검사 추가

주요 변경 사항

  • 개인 일정 추가 API GetMapping → PostMapping 수정
  • 일정 소유자 다름 Exception 추가
  • 일정 조회 쿼리 Scope 추가
  • Domain 초기화 Exception internal 적용

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added feat 새로운 기능을 추가 할 경우 refactor 코드 리팩토링 할 경우 labels Nov 27, 2022
@khcho0125 khcho0125 self-assigned this Nov 27, 2022
@codecov
Copy link

codecov bot commented Nov 27, 2022 •
edited
Loading

Codecov Report

Merging #157 (12df0a4) into main (6bf03bf) will increase coverage by 0.64%.
The diff coverage is 61.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #157      +/-   ##
============================================
+ Coverage     42.51%   43.16%   +0.64%     
- Complexity      260      272      +12     
============================================
  Files           171      175       +4     
  Lines          1470     1522      +52     
  Branches         46       51       +5     
============================================
+ Hits            625      657      +32     
- Misses          842      862      +20     
  Partials          3        3
Impacted Files Coverage Δ
.../exception/NotInitializationPropertiesException.kt 0.00% <0.00%> (ø)
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...persistence/schedule/SchedulePersistenceAdapter.kt 0.00% <0.00%> (ø)
...omit/simtong/domain/schedule/WebScheduleAdapter.kt 0.00% <0.00%> (ø)
.../dto/request/ChangeIndividualScheduleWebRequest.kt 0.00% <0.00%> (ø)
...in/schedule/dto/ChangeIndividualScheduleRequest.kt 100.00% <100.00%> (ø)
...chedule/usecase/ChangeIndividualScheduleUseCase.kt 100.00% <100.00%> (ø)
...main/schedule/usecase/ChangeSpotScheduleUseCase.kt 100.00% <100.00%> (ø)
...main/schedule/usecase/EntireSpotScheduleUseCase.kt 100.00% <100.00%> (ø)
...simtong/domain/schedule/error/ScheduleErrorCode.kt 71.42% <100.00%> (+4.76%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf03bf...12df0a4. Read the comment docs.

softpeanut
softpeanut previously approved these changes Nov 27, 2022
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Nov 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit b7c200d into main Nov 27, 2022
@khcho0125 khcho0125 deleted the feature/156-change-individual-schedule branch November 27, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softpeanut softpeanut softpeanut approved these changes

Assignees

@khcho0125 khcho0125

Labels
feat 새로운 기능을 추가 할 경우 refactor 코드 리팩토링 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

개인 일정 변경 기능
2 participants
@khcho0125 @softpeanut