Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#149) 전체 지점 일정 조회 #151

Merged
merged 7 commits into from
Nov 26, 2022

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Nov 25, 2022

작업 내용 설명

  • 전체 지점 일정 조회 UseCase
  • 해당 달 전체 지점 일정 조회 Query 추가

주요 변경 사항

  • Domain Properties Prefix 변경

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Nov 25, 2022
@khcho0125 khcho0125 added this to the 2차 기능 마감 milestone Nov 25, 2022
@khcho0125 khcho0125 self-assigned this Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #151 (4d7b470) into main (3eab485) will increase coverage by 0.45%.
The diff coverage is 53.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #151      +/-   ##
============================================
+ Coverage     41.94%   42.39%   +0.45%     
- Complexity      246      256      +10     
============================================
  Files           163      167       +4     
  Lines          1359     1420      +61     
  Branches         44       44              
============================================
+ Hits            570      602      +32     
- Misses          787      816      +29     
  Partials          2        2              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...persistence/schedule/SchedulePersistenceAdapter.kt 0.00% <0.00%> (ø)
.../simtong/persistence/schedule/vo/SpotScheduleVo.kt 0.00% <0.00%> (ø)
.../domain/schedule/dto/EntireSpotScheduleResponse.kt 100.00% <100.00%> (ø)
...main/schedule/usecase/EntireSpotScheduleUseCase.kt 100.00% <100.00%> (ø)
...n/team/comit/simtong/domain/auth/model/AuthCode.kt 100.00% <100.00%> (ø)
...m/comit/simtong/domain/auth/model/AuthCodeLimit.kt 100.00% <100.00%> (ø)
...m/comit/simtong/domain/schedule/vo/SpotSchedule.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eab485...4d7b470. Read the comment docs.

@khcho0125 khcho0125 removed this from the 2차 기능 마감 milestone Nov 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit 5c4feeb into main Nov 26, 2022
@khcho0125 khcho0125 deleted the feature/149-entire-spot-schedule branch November 26, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

모든 지점 일정 보기
2 participants