Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#143) 지점 일정 삭제 기능 #146

Merged
merged 6 commits into from
Nov 24, 2022

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • RemoveSpotSchedule UseCase 추가

주요 변경 사항

  • delete schedule 쿼리 추가

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Nov 23, 2022
@khcho0125 khcho0125 self-assigned this Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #146 (e383116) into main (f26213f) will increase coverage by 0.41%.
The diff coverage is 65.21%.

❗ Current head e383116 differs from pull request most recent head b5d653e. Consider uploading reports for the commit b5d653e to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #146      +/-   ##
============================================
+ Coverage     42.22%   42.64%   +0.41%     
- Complexity      240      246       +6     
============================================
  Files           159      160       +1     
  Lines          1338     1360      +22     
  Branches         45       48       +3     
============================================
+ Hits            565      580      +15     
- Misses          769      776       +7     
  Partials          4        4              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...persistence/schedule/SchedulePersistenceAdapter.kt 0.00% <0.00%> (ø)
.../team/comit/simtong/schedule/WebScheduleAdapter.kt 0.00% <0.00%> (ø)
...main/schedule/usecase/RemoveSpotScheduleUseCase.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26213f...b5d653e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit 4a328de into main Nov 24, 2022
@khcho0125 khcho0125 deleted the feature/143-remove-spot-schedule branch November 24, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

지점 일정 삭제 기능 설계
2 participants