Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge: (#118) 이메일 중복 검사 설계 #119

Merged
merged 8 commits into from
Oct 15, 2022
Merged

merge: (#118) 이메일 중복 검사 설계 #119

merged 8 commits into from
Oct 15, 2022

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Oct 14, 2022 •
edited
Loading

작업 내용 설명

  • 이메일 중복 검사

주요 변경 사항

  • security config /commons/email/overlap

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Oct 14, 2022
@khcho0125 khcho0125 added this to the 1차 기능 마감 milestone Oct 14, 2022
@khcho0125 khcho0125 self-assigned this Oct 14, 2022
softpeanut
softpeanut reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overlap이라는 단어를 duplication이나 exists로 바꾸는 건 어때요?

...ation/src/main/kotlin/team/comit/simtong/common/dto/request/WebCheckEmailOverlapException.kt Outdated Show resolved Hide resolved
@khcho0125 khcho0125 removed this from the 1차 기능 마감 milestone Oct 15, 2022
@codecov
Copy link

codecov bot commented Oct 15, 2022 •
edited
Loading

Codecov Report

Merging #119 (fa573b3) into main (7229601) will increase coverage by 0.18%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #119      +/-   ##
============================================
+ Coverage     39.26%   39.45%   +0.18%     
- Complexity      189      192       +3     
============================================
  Files           134      135       +1     
  Lines          1090     1100      +10     
  Branches         35       35              
============================================
+ Hits            428      434       +6     
- Misses          661      665       +4     
  Partials          1        1
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...tlin/team/comit/simtong/common/WebCommonAdapter.kt 0.00% <0.00%> (ø)
...omain/user/usecase/CheckEmailDuplicationUseCase.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7229601...fa573b3. Read the comment docs.

softpeanut
softpeanut previously approved these changes Oct 15, 2022
View reviewed changes
@softpeanut softpeanut self-requested a review October 15, 2022 04:00
@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit e670edc into main Oct 15, 2022
@khcho0125 khcho0125 deleted the feature/118-check-email-overlap branch October 15, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softpeanut softpeanut softpeanut approved these changes

Assignees

@khcho0125 khcho0125

Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

이메일 중복 검사 기능 설계
2 participants
@khcho0125 @softpeanut