Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#103) 비밀번호 변경 기능 #117

Merged
merged 5 commits into from
Oct 15, 2022
Merged

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Oct 14, 2022

작업 내용 설명

  • 비밀번호 변경 기능 설계

주요 변경 사항

  • 비밀번호 초기화 수정 #109 누락된 WebResetPasswordRequest commons 패키지로 이동
  • 비밀번호 초기화 security config /commons/password → /commons/password/initialization
  • 비밀번호 변경 security config /commons/password

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Oct 14, 2022
@khcho0125 khcho0125 self-assigned this Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #117 (c8ee4fa) into main (17dc102) will increase coverage by 0.50%.
The diff coverage is 55.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #117      +/-   ##
============================================
+ Coverage     38.75%   39.26%   +0.50%     
- Complexity      182      189       +7     
============================================
  Files           131      134       +3     
  Lines          1063     1090      +27     
  Branches         33       35       +2     
============================================
+ Hits            412      428      +16     
- Misses          650      661      +11     
  Partials          1        1              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...tlin/team/comit/simtong/common/WebCommonAdapter.kt 0.00% <0.00%> (ø)
...ong/common/dto/request/WebChangePasswordRequest.kt 0.00% <0.00%> (ø)
...tong/common/dto/request/WebResetPasswordRequest.kt 0.00% <ø> (ø)
...comit/simtong/user/dto/request/WebSignUpRequest.kt 0.00% <ø> (ø)
...t/simtong/domain/user/dto/ChangePasswordRequest.kt 100.00% <100.00%> (ø)
...mtong/domain/user/usecase/ChangePasswordUseCase.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17dc102...c8ee4fa. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit 7229601 into main Oct 15, 2022
@khcho0125 khcho0125 deleted the feature/103-change-password branch October 15, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

비밀번호 변경 기능
2 participants