Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#84) 로그인 안된 상태에서 메뉴 조회 #105

Merged
merged 9 commits into from
Oct 11, 2022

Conversation

softpeanut
Copy link
Member

@softpeanut softpeanut commented Oct 11, 2022

작업 내용 설명

  • QueryPublicMenuUseCase

주요 변경 사항

  • GET /menu 타입 형식 지정
  • 메뉴 조회 security permission 설정

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the feat 새로운 기능을 추가 할 경우 label Oct 11, 2022
@softpeanut softpeanut self-assigned this Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #105 (98d926b) into main (2d3e9a3) will decrease coverage by 0.03%.
The diff coverage is 36.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #105      +/-   ##
============================================
- Coverage     37.13%   37.10%   -0.04%     
- Complexity      166      168       +2     
============================================
  Files           124      125       +1     
  Lines           999     1016      +17     
  Branches         27       27              
============================================
+ Hits            371      377       +6     
- Misses          625      636      +11     
  Partials          3        3              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...simtong/persistence/menu/MenuPersistenceAdapter.kt 0.00% <0.00%> (ø)
...n/kotlin/team/comit/simtong/menu/WebMenuAdapter.kt 0.00% <0.00%> (ø)
...ong/domain/menu/usecase/QueryMenuByMonthUseCase.kt 100.00% <100.00%> (ø)
...tong/domain/menu/usecase/QueryPublicMenuUseCase.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3e9a3...98d926b. Read the comment docs.

@softpeanut softpeanut marked this pull request as ready for review October 11, 2022 10:11
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125
Copy link
Member

LGTM 👍

@softpeanut softpeanut merged commit 59b8b3c into main Oct 11, 2022
@softpeanut softpeanut deleted the feature/84-query-menu branch October 11, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

로그인 안된 상태에서 메뉴 조회
2 participants