Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#99) 프로필 사진 변경 기능 #100

Merged
merged 12 commits into from
Oct 11, 2022

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Oct 3, 2022

작업 내용 설명

  • 프로필 사진 변경 기능

주요 변경 사항

  • Security Config /users/profile 추가
  • CheckFilePort 추가
  • ManageFilePort → UploadFilePort

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the feat 새로운 기능을 추가 할 경우 label Oct 3, 2022
@khcho0125 khcho0125 self-assigned this Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #100 (952cc31) into main (2d3e9a3) will increase coverage by 0.93%.
The diff coverage is 74.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #100      +/-   ##
============================================
+ Coverage     37.13%   38.07%   +0.93%     
- Complexity      166      175       +9     
============================================
  Files           124      128       +4     
  Lines           999     1027      +28     
  Branches         27       28       +1     
============================================
+ Hits            371      391      +20     
- Misses          625      633       +8     
  Partials          3        3              
Impacted Files Coverage Δ
...am/comit/simtong/global/security/SecurityConfig.kt 0.00% <0.00%> (ø)
...n/kotlin/team/comit/simtong/user/WebUserAdapter.kt 0.00% <0.00%> (ø)
...g/user/dto/request/WebChangeProfileImageRequest.kt 0.00% <0.00%> (ø)
.../simtong/domain/file/usecase/UploadImageUseCase.kt 94.44% <100.00%> (ø)
...mtong/domain/user/dto/ChangeProfileImageRequest.kt 100.00% <100.00%> (ø)
...g/domain/user/usecase/ChangeProfileImageUseCase.kt 100.00% <100.00%> (ø)
...m/comit/simtong/domain/file/error/FileErrorCode.kt 75.00% <100.00%> (+3.57%) ⬆️
...domain/file/exception/NotFoundFilePathException.kt 100.00% <100.00%> (ø)
...m/comit/simtong/thirdparty/storage/AwsS3Adapter.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3e9a3...952cc31. Read the comment docs.

@khcho0125 khcho0125 mentioned this pull request Oct 8, 2022
@khcho0125 khcho0125 changed the title add: (#99) 프로필 사진 변경 기능 merge: (#99) 프로필 사진 변경 기능 Oct 8, 2022
Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChangeProfile과 같은 이름은 프로필 전체를 변경하는 느낌이 들어서 ProfileImage로 이름을 변경하는 것이 좋을 것 같아요

@khcho0125
Copy link
Member Author

ChangeProfile과 같은 이름은 프로필 전체를 변경하는 느낌이 들어서 ProfileImage로 이름을 변경하는 것이 좋을 것 같아요

ChangeProfileImage로 변경하도록 하겠습니다.

@khcho0125 khcho0125 marked this pull request as draft October 9, 2022 17:49
@khcho0125 khcho0125 marked this pull request as ready for review October 10, 2022 11:23
softpeanut
softpeanut previously approved these changes Oct 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khcho0125 khcho0125 merged commit f07a5d8 into main Oct 11, 2022
@khcho0125 khcho0125 deleted the feature/99-change-profile-image branch October 11, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

프로필 사진 변경 기능
2 participants