-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge: (#99) 프로필 사진 변경 기능 #100
Conversation
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
============================================
+ Coverage 37.13% 38.07% +0.93%
- Complexity 166 175 +9
============================================
Files 124 128 +4
Lines 999 1027 +28
Branches 27 28 +1
============================================
+ Hits 371 391 +20
- Misses 625 633 +8
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChangeProfile과 같은 이름은 프로필 전체를 변경하는 느낌이 들어서 ProfileImage로 이름을 변경하는 것이 좋을 것 같아요
ChangeProfileImage로 변경하도록 하겠습니다. |
simtong-infrastructure/src/main/kotlin/team/comit/simtong/thirdparty/storage/AwsS3Adapter.kt
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
작업 내용 설명
주요 변경 사항
체크리스트
관련 이슈