Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

매개변수 제거 - File Name #134

Closed
khcho0125 opened this issue Oct 24, 2022 · 2 comments · Fixed by #136
Closed

매개변수 제거 - File Name #134

khcho0125 opened this issue Oct 24, 2022 · 2 comments · Fixed by #136
Assignees
@khcho0125
Labels
refactor 코드 리팩토링 할 경우
Milestone
1차 기능 마감

Comments

@khcho0125
Copy link
Member

khcho0125 commented Oct 24, 2022 •
edited
Loading

AS-IS

  • AwsS3Adapter inputS3 fileName 필요없는 매개변수

TO-BE

  • 매개변수 변경
  • file, fileName → file
@khcho0125 khcho0125 added the refactor 코드 리팩토링 할 경우 label Oct 24, 2022
@softpeanut
Copy link
Member

AS-IS와 TO-BE를 보고 무엇을 위한 것인지 잘 파악이 되지 않아요
조금 더 자세하게 적어주시면 좋을 것 같아요 😃

@khcho0125
Copy link
Member Author

AS-IS와 TO-BE를 보고 무엇을 위한 것인지 잘 파악이 되지 않아요

조금 더 자세하게 적어주시면 좋을 것 같아요 😃

모바일로 적어서... 수정하겠습니다 😁

@khcho0125 khcho0125 self-assigned this Oct 25, 2022
@khcho0125 khcho0125 added this to the 1차 기능 마감 milestone Oct 25, 2022
khcho0125 added a commit that referenced this issue Oct 29, 2022
@khcho0125
refactor: (#134) 필요없는 매개변수 정리
eda8202
@khcho0125 khcho0125 mentioned this issue Oct 29, 2022
Merged
4 tasks
@khcho0125 khcho0125 changed the title 코드 스타일 변경 - File Name 매개변수 제거 - File Name Oct 29, 2022
khcho0125 added a commit that referenced this issue Oct 30, 2022
@khcho0125
merge: (#134) InputS3 매개변수 정리 (#136)
886fd38
Repository owner moved this from Todo to Done in SimTong-Backend Backlog Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khcho0125 khcho0125

Labels
refactor 코드 리팩토링 할 경우
Projects
SimTong-Backend Backlog
Status: Done
Milestone
1차 기능 마감
Development

Successfully merging a pull request may close this issue.

merge: (#134) InputS3 매개변수 정리 Team-ComIT/SimTong-Backend
2 participants
@softpeanut @khcho0125