Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mt 1083 #191

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Mt 1083 #191

merged 3 commits into from
Oct 7, 2022

Conversation

jameskeith
Copy link
Contributor

No description provided.

Copy link
Contributor

@tamayok tamayok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.


internal class DefaultVisitorStorage(
private val storage: KeyValueDao<String, PersistentItem>,
private val hashingProvider: HashingProvider = DefaultHashingProvider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see this used anywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - removed.

Copy link
Contributor

@tamayok tamayok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jameskeith jameskeith merged commit 4b22a92 into release/1.5.0 Oct 7, 2022
@jameskeith jameskeith deleted the mt-1083 branch October 7, 2022 14:47
jameskeith added a commit that referenced this pull request Oct 19, 2022
* [MT-1116] Add support for default mappings - all_events/all_views (#188)

* Mt 1107 (#181)

* Bug fix: sessionCounting + logical resolution

* Cleanup imports

* Minor fix for app_uuid

* Updates per code review

Co-authored-by: Karen Tamayo <[email protected]>
Co-authored-by: Karen Tamayo <[email protected]>

* [MT-1112] - moved profile override init earlier (#183)

Co-authored-by: Karen Tamayo <[email protected]>

* [MT-960] - added missing proguard rules for new classes (#184)

Co-authored-by: Karen Tamayo <[email protected]>

* Update TealiumTests + AppCollectorTests

* Add support for default mappings - all_events/all_views

* Update commandList to use List

* Edit RemoteCommandDispatcher to version 1.2.0

Co-authored-by: Karen Tamayo <[email protected]>
Co-authored-by: Karen Tamayo <[email protected]>
Co-authored-by: James Keith <[email protected]>

* [MT-1083] - Visitor Switching (#191)

* visitor switching

* Datalayer update notifications + tests/fixes

* Edge case fixes, and single hash

* [MT-1047] QueryParameterProvider + WebView loading (#185)

* QuerParamProvider + Updates to TagManagementDispatcher

* Clean up tests

* Move provideParameters call off main thread

* WebView init synchronization (#187)

Co-authored-by: Karen Tamayo <[email protected]>
Co-authored-by: Karen Tamayo <[email protected]>
Co-authored-by: James Keith <[email protected]>

* Release version and dependency updates (#192)

* Slight increment to delay on test

* [MT-1149] - Visitor Switching  (#194)

* Visitor switching enhancements + param providers timeout

* WebViewLoader Tests

Co-authored-by: Karen Tamayo <[email protected]>
Co-authored-by: Karen Tamayo <[email protected]>

* gradle wrapper + test update

Co-authored-by: Karen Tamayo <[email protected]>
Co-authored-by: Karen Tamayo <[email protected]>
Co-authored-by: Karen Tamayo <[email protected]>
Co-authored-by: James Keith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants