-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic support for generic structs and enums #483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeXitoi
requested changes
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It lacks a few things:
- ChangeLog entry
- Documentation
- Maybe a relevant example
- A test with no bound, and an ignore field
- A test with a bound that is not StructOpt (FromStr seems a good candidat?)
Co-authored-by: Guillaume P. <[email protected]>
njeffords
force-pushed
the
derive_generic
branch
from
June 24, 2021 13:50
8681096
to
c37d9c8
Compare
TeXitoi
reviewed
Jun 29, 2021
TeXitoi
approved these changes
Jul 1, 2021
Thanks! |
v0.3.22 published |
This was referenced Oct 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides (at least basic) support for generics when deriving
StructOpt
(issue #128). It's probably not the ideal final implementation, but from what I can see, it improves the situation and makes some use cases possible.