Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value #312

Merged
merged 3 commits into from
Dec 29, 2019
Merged

Default value #312

merged 3 commits into from
Dec 29, 2019

Conversation

CreepySkeleton
Copy link
Collaborator

@CreepySkeleton CreepySkeleton commented Dec 21, 2019

This is not meant to be released with the next patch, just some ongoing work.

Closes #123
Closes #142
Closes #150

TODO: docs, changelog

@CreepySkeleton
Copy link
Collaborator Author

Ready for review

structopt-derive/src/attrs.rs Outdated Show resolved Hide resolved
structopt-derive/src/parse.rs Show resolved Hide resolved
tests/default_value.rs Show resolved Hide resolved
@TeXitoi
Copy link
Owner

TeXitoi commented Dec 28, 2019

Overall great code!

@CreepySkeleton
Copy link
Collaborator Author

Ready

Copy link
Owner

@TeXitoi TeXitoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

structopt-derive/src/attrs.rs Outdated Show resolved Hide resolved
structopt-derive/src/attrs.rs Show resolved Hide resolved
structopt-derive/src/attrs.rs Outdated Show resolved Hide resolved
@TeXitoi
Copy link
Owner

TeXitoi commented Dec 29, 2019

A warning break the error message tests

@CreepySkeleton
Copy link
Collaborator Author

Not anymore

src/lib.rs Show resolved Hide resolved
@CreepySkeleton CreepySkeleton merged commit eaeb653 into master Dec 29, 2019
@CreepySkeleton CreepySkeleton deleted the default_value branch December 29, 2019 15:53
@CreepySkeleton
Copy link
Collaborator Author

Number of issues is less than 15! New achievement! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default_value from lazy Default Feature Request: useDefault, if implemented default_value and Option?
2 participants